Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-27 Thread J, KEERTHY
On Fri, Aug 26, 2011 at 9:46 PM, Guenter Roeck wrote: > On Fri, 2011-08-26 at 07:17 -0400, J, KEERTHY wrote: >> On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck >> wrote: >> > On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: >> >> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: >

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-26 Thread Guenter Roeck
On Fri, 2011-08-26 at 07:17 -0400, J, KEERTHY wrote: > On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck > wrote: > > On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: > >> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: > >> > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck > >> >

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-26 Thread J, KEERTHY
On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck wrote: > On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: >> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: >> > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck >> > wrote: >> > > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 12:39 -0400, J, KEERTHY wrote: > On Thu, Aug 25, 2011 at 9:49 PM, Guenter Roeck > wrote: > > On Thu, 2011-08-25 at 12:04 -0400, J, KEERTHY wrote: > >> On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck > >> wrote: > >> > On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread J, KEERTHY
On Thu, Aug 25, 2011 at 9:49 PM, Guenter Roeck wrote: > On Thu, 2011-08-25 at 12:04 -0400, J, KEERTHY wrote: >> On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck >> wrote: >> > On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: >> >> On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck >> >> wr

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 12:04 -0400, J, KEERTHY wrote: > On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck > wrote: > > On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: > >> On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck > >> wrote: > >> > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread J, KEERTHY
On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck wrote: > On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: >> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: >> > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck >> > wrote: >> > > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread J, KEERTHY
On Thu, Aug 25, 2011 at 7:36 PM, Guenter Roeck wrote: > On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: >> On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck >> wrote: >> > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: >> >> On chip temperature sensor driver. The driver monito

Re: [lm-sensors] [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote: > On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: > > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck > > wrote: > > > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: > > >> On chip temperature sensor driver. The driver m

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, 2011-08-25 at 03:24 -0400, Todd Poynor wrote: > On Wed, Aug 24, 2011 at 08:07:12PM +0530, Keerthy wrote: > ... > > + temp_sensor->phy_base = ioremap(mem->start, resource_size(mem)); > > Check NULL return. > > temp_sensor->phy_base is never iounmapped in error paths or _remove > function

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Guenter Roeck
On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote: > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck > wrote: > > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: > >> On chip temperature sensor driver. The driver monitors the temperature of > >> the MPU subsystem of the OMAP4. It

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread J, KEERTHY
On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck wrote: > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: >> On chip temperature sensor driver. The driver monitors the temperature of >> the MPU subsystem of the OMAP4. It sends notifications to the user space if >> the temperature crosses u

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-25 Thread Todd Poynor
On Wed, Aug 24, 2011 at 08:07:12PM +0530, Keerthy wrote: ... > + temp_sensor->phy_base = ioremap(mem->start, resource_size(mem)); Check NULL return. temp_sensor->phy_base is never iounmapped in error paths or _remove function. ... > +static int __devexit omap_temp_sensor_remove(struct platfo

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-24 Thread J, KEERTHY
On Thu, Aug 25, 2011 at 1:22 AM, Janakiram Sistla wrote: > > > On Wed, Aug 24, 2011 at 1:18 PM, J, KEERTHY wrote: >> >> On Wed, Aug 24, 2011 at 10:06 PM, Janakiram Sistla >> wrote: >> > Hi Keerthy, >> > >> > Can you please point me the TRM of 4430 or 4460 where it reads the on >> > die >> > temp

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-24 Thread J, KEERTHY
On Wed, Aug 24, 2011 at 10:06 PM, Janakiram Sistla wrote: > Hi Keerthy, > > Can you please point me the TRM of 4430 or 4460 where it reads the on die > temperature sensor used is TMP103. I am referring to public TRM on TI site. Sorry my bad! I shall remove that. > > Regards, > Sistla. > > On Wed

Re: [PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-24 Thread Guenter Roeck
On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy wrote: > On chip temperature sensor driver. The driver monitors the temperature of > the MPU subsystem of the OMAP4. It sends notifications to the user space if > the temperature crosses user defined thresholds via kobject_uevent interface. > The us

[PATCH 6/6 V3] hwmon: OMAP4: On die temperature sensor driver

2011-08-24 Thread Keerthy
On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs n