Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-09 Thread Mark Brown
On Fri, Oct 09, 2009 at 07:28:03AM +0300, Eero Nurkkala wrote: > On Thu, 2009-10-08 at 18:01 +0200, ext Mark Brown wrote: > > I'd expect the usage would be that after the audio subsystem has been > > idle for some configurable period of time the core would bring the > > audio subsystem down to

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Eero Nurkkala
On Thu, 2009-10-08 at 18:01 +0200, ext Mark Brown wrote: > On 8 Oct 2009, at 16:44, wrote: > > > Mark Brown wrote: > >> > >>> Also, this is regulator > >>> thing > >>> is highly platform dependent, not aic3x related really at all, so is > >>> this the cor

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Mark Brown
On 8 Oct 2009, at 16:44, wrote: Mark Brown wrote: Also, this is regulator thing is highly platform dependent, not aic3x related really at all, so is this the correct place... Just a thought, dont take it too seriously ;) I'm not sure what you mea

RE: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread ext-Eero.Nurkkala
Mark Brown wrote: >> Will this ever be revisited =) ? If so, I think there's going to be a >> jungle in finding the right spots - you need to remember the bypass >> paths also (bias is not on necessarily). > > The bias is always on when any path through the chip is on, this was > fixed in either .

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Mark Brown
On Thu, Oct 08, 2009 at 03:17:07PM +0300, Eero Nurkkala wrote: > Will this ever be revisited =) ? If so, I think there's going to be a > jungle in finding the right spots - you need to remember the bypass > paths also (bias is not on necessarily). The bias is always on when any path through the c

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Mark Brown
On Thu, Oct 08, 2009 at 02:58:56PM +0300, Eduardo Valentin wrote: > This patch adds initial usage of regulator framework to control avdd_dac > inside tlv320aic3x ASoC codec driver. If you're going to do this you should add support for all the supplies of the device, not just one of them. The ext

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Eduardo Valentin
On Thu, Oct 08, 2009 at 02:17:07PM +0200, Nurkkala Eero.An (EXT-Offcode/Oulu) wrote: > On Thu, 2009-10-08 at 13:58 +0200, Valentin Eduardo (Nokia-D/Helsinki) > wrote: > > From: Eduardo Valentin > > > > This patch adds initial usage of regulator framework to control avdd_dac > > inside tlv320aic3

Re: [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Eero Nurkkala
On Thu, 2009-10-08 at 13:58 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: > From: Eduardo Valentin > > This patch adds initial usage of regulator framework to control avdd_dac > inside tlv320aic3x ASoC codec driver. > > The refcount to avdd_dac is increased / decreased > only during probe a

[PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac

2009-10-08 Thread Eduardo Valentin
From: Eduardo Valentin This patch adds initial usage of regulator framework to control avdd_dac inside tlv320aic3x ASoC codec driver. The refcount to avdd_dac is increased / decreased only during probe and remove. Here it is still needed to implement proper enable/disable regulator depending on