Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-02 Thread Alan Cox
> Is there any standardisation of the ABIs whcih these drivers offer? If > so, does this new driver comply with that? There was an attempt to sort this out but Linux vetoed it because he is under the delusion that light sensors are input devices. That doesn't work in many use cases as you have to

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-02 Thread Hemanth V
- Original Message - From: "Andrew Morton" To: "Jonathan Cameron" Cc: "Hemanth V" ; ; ; "Daniel Mack" ; "Jonathan Cameron" ; "Wolfram Sang" Sent: Wednesday, June 02, 2010 2:24 AM Subject: Re: [PATCH V2] misc : ROHM BH1780

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Jonathan Cameron
On 06/01/10 21:54, Andrew Morton wrote: > On Tue, 01 Jun 2010 21:39:10 +0100 > Jonathan Cameron wrote: > >>> >>> It would be most useful if the changelog were to fully describe the >>> proposed kernel<->userspace interface. That's the most important part >>> of the driver, because it's the only

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Andrew Morton
On Tue, 01 Jun 2010 21:39:10 +0100 Jonathan Cameron wrote: > > > > It would be most useful if the changelog were to fully describe the > > proposed kernel<->userspace interface. That's the most important part > > of the driver, because it's the only part we can never change. > > > > There is a

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Jonathan Cameron
On 06/01/10 21:27, Daniel Mack wrote: > On Tue, Jun 01, 2010 at 01:12:44PM -0700, Andrew Morton wrote: >> On Mon, 24 May 2010 16:34:25 +0530 (IST) >> "Hemanth V" wrote: >> >>> This patch adds support for ROHM BH1780GLI Ambient light sensor. >>> >>> BH1780 supports I2C interface. Driver supports re

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Andrew Morton
On Tue, 1 Jun 2010 22:27:15 +0200 Daniel Mack wrote: > On Tue, Jun 01, 2010 at 01:12:44PM -0700, Andrew Morton wrote: > > On Mon, 24 May 2010 16:34:25 +0530 (IST) > > "Hemanth V" wrote: > > > > > This patch adds support for ROHM BH1780GLI Ambient light sensor. > > > > > > BH1780 supports I2C i

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Jonathan Cameron
On 06/01/10 21:12, Andrew Morton wrote: > > I re-added your reviewers to the cc... > > On Mon, 24 May 2010 16:34:25 +0530 (IST) > "Hemanth V" wrote: > >> This patch adds support for ROHM BH1780GLI Ambient light sensor. >> >> BH1780 supports I2C interface. Driver supports read/update of power st

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Daniel Mack
On Tue, Jun 01, 2010 at 01:12:44PM -0700, Andrew Morton wrote: > On Mon, 24 May 2010 16:34:25 +0530 (IST) > "Hemanth V" wrote: > > > This patch adds support for ROHM BH1780GLI Ambient light sensor. > > > > BH1780 supports I2C interface. Driver supports read/update of power state > > and > > rea

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-06-01 Thread Andrew Morton
I re-added your reviewers to the cc... On Mon, 24 May 2010 16:34:25 +0530 (IST) "Hemanth V" wrote: > This patch adds support for ROHM BH1780GLI Ambient light sensor. > > BH1780 supports I2C interface. Driver supports read/update of power state and > read of lux value (through SYSFS). Writing v

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-05-26 Thread Hemanth V
- Original Message - From: "Jonathan Cameron" > On 05/26/10 09:30, Hemanth V wrote: >>> From: Hemanth V >>> Date: Fri, 21 May 2010 15:52:03 +0530 >>> Subject: [PATCH] misc: ROHM BH1780GLI Ambient light sensor Driver >>> >>> This patch adds support for ROHM BH1780GLI Ambient light sensor. >

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-05-26 Thread Jonathan Cameron
On 05/26/10 09:30, Hemanth V wrote: >> From: Hemanth V >> Date: Fri, 21 May 2010 15:52:03 +0530 >> Subject: [PATCH] misc: ROHM BH1780GLI Ambient light sensor Driver >> >> This patch adds support for ROHM BH1780GLI Ambient light sensor. >> >> BH1780 supports I2C interface. Driver supports read/upda

Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-05-26 Thread Hemanth V
> From: Hemanth V > Date: Fri, 21 May 2010 15:52:03 +0530 > Subject: [PATCH] misc: ROHM BH1780GLI Ambient light sensor Driver > > This patch adds support for ROHM BH1780GLI Ambient light sensor. > > BH1780 supports I2C interface. Driver supports read/update of power state and > read of lux value (

[PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

2010-05-24 Thread Hemanth V
From: Hemanth V Date: Fri, 21 May 2010 15:52:03 +0530 Subject: [PATCH] misc: ROHM BH1780GLI Ambient light sensor Driver This patch adds support for ROHM BH1780GLI Ambient light sensor. BH1780 supports I2C interface. Driver supports read/update of power state and read of lux value (through SYSFS)