Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-13 Thread Jason Cooper
On Fri, Jun 13, 2014 at 12:00:31PM +0530, Sricharan R wrote: > Ok, if this is not qualifying as a separate patch then i will merge > this with other patches in the series which touch them. A good general rule of thumb is to just run checkpatch on the patches, not the source files. This way, w

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 09:35 PM, Joe Perches wrote: > On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote: > > Hi Jason. > >>> But bugfix backports haven't been much of an issue in >>> other subsystems with fairly active whitespace/style >>> changes. >> >> Most of the mvebu fixes w

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Joe Perches
On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote: Hi Jason. > > But bugfix backports haven't been much of an issue in > > other subsystems with fairly active whitespace/style > > changes. > > Most of the mvebu fixes we've had that failed to apply were generally > due to a large whitespace c

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Jason Cooper
Hey Joe, On Thu, Jun 12, 2014 at 07:18:31AM -0700, Joe Perches wrote: > On Thu, 2014-06-12 at 19:05 +0530, Sricharan R wrote: > > On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote: > > > On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: > > >> diff --git a/drivers/irqchip/irq-crossb

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Joe Perches
On Thu, 2014-06-12 at 19:05 +0530, Sricharan R wrote: > On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote: > > On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: > >> diff --git a/drivers/irqchip/irq-crossbar.c > >> b/drivers/irqchip/irq-crossbar.c [] > >> @@ -34,7 +34,8 @@ struct cr

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> remove un-necessary space in function pointer. >> >> Fixes checkpatch warning: >> WARNING: Unnecessary space before function pointer argume

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Jason Cooper
On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: > From: Nishanth Menon > > remove un-necessary space in function pointer. > > Fixes checkpatch warning: > WARNING: Unnecessary space before function pointer arguments > #37: FILE: drivers/irqchip/irq-crossbar.c:37: > +void (*writ

[PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
From: Nishanth Menon remove un-necessary space in function pointer. Fixes checkpatch warning: WARNING: Unnecessary space before function pointer arguments #37: FILE: drivers/irqchip/irq-crossbar.c:37: + void (*write) (int, int); WARNING: Missing a blank line after declarations + in