[PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Chandrabhanu Mahapatra
The printk in DSSDBG function definition is replaced with dynamic debug enabled pr_debug(). The use of dynamic debugging provides more flexibility as each debug statement can be enabled or disabled dynamically on basis of source filename, line number, module name etc. by writing to a control file

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: The printk in DSSDBG function definition is replaced with dynamic debug enabled pr_debug(). The use of dynamic debugging provides more flexibility as each debug statement can be enabled or disabled dynamically on basis of

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Mahapatra, Chandrabhanu
On Fri, Sep 28, 2012 at 4:52 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: The printk in DSSDBG function definition is replaced with dynamic debug enabled pr_debug(). The use of dynamic debugging provides more flexibility as

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 17:00 +0530, Mahapatra, Chandrabhanu wrote: I think you could just do: #ifdef DSS_SUBSYS_NAME #ifdef pr_fmt #undef pr_fmt #endif #define pr_fmt(fmt) DSS_SUBSYS_NAME : fmt #endif For the case where there's no DSS_SUBSYS_NAME, there's no need to undef