Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-03-02 Thread Tony Lindgren
* Tomi Valkeinen [110228 22:27]: > On Mon, 2011-02-28 at 19:39 -0600, Tony Lindgren wrote: > > * Tomi Valkeinen [110228 07:07]: > > > > > > Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb, > > > which hopefully nobody uses anymore (right =), and there's no simple way > > > t

Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-28 Thread Tomi Valkeinen
On Mon, 2011-02-28 at 19:39 -0600, Tony Lindgren wrote: > * Tomi Valkeinen [110228 07:07]: > > > > Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb, > > which hopefully nobody uses anymore (right =), and there's no simple way > > to make it modular and neat. > > How about let

Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-28 Thread Tony Lindgren
* Tomi Valkeinen [110228 07:07]: > > Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb, > which hopefully nobody uses anymore (right =), and there's no simple way > to make it modular and neat. How about let's make mach-omap2 boards all use the new code? That way the old code

Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-28 Thread Tomi Valkeinen
On Mon, 2011-02-28 at 08:47 -0600, Jarkko Nikula wrote: > On Thu, 24 Feb 2011 13:26:44 -0800 > Tony Lindgren wrote: > > > We should avoid selecting driver related things, otherwise we can never > > build a tiny kernel with initramfs with everything as modules. > > > > Can you see if adding depen

Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-28 Thread Jarkko Nikula
On Thu, 24 Feb 2011 13:26:44 -0800 Tony Lindgren wrote: > We should avoid selecting driver related things, otherwise we can never > build a tiny kernel with initramfs with everything as modules. > > Can you see if adding depends to the LCD panel option does the trick > instead? > True and as lc

Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-24 Thread Tony Lindgren
Hi, * Jarkko Nikula [110220 12:13]: > There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not > set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set. > > drivers/built-in.o: In function `sdp2430_panel_disable': > drivers/video/omap/lcd_2430sdp.c:123: undef

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

2011-02-20 Thread Jarkko Nikula
There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set. drivers/built-in.o: In function `sdp2430_panel_disable': drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8' drivers/vid