[PATCH resend] video: omap24xxcam: Fix compilation

2011-02-07 Thread Thomas Weber
Add linux/sched.h because of missing declaration of TASK_NORMAL. This patch fixes the following error: drivers/media/video/omap24xxcam.c: In function 'omap24xxcam_vbq_complete': drivers/media/video/omap24xxcam.c:415: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/media/video

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-19 Thread David Cohen
Hi Sakari and Felipe, On Tue, Feb 15, 2011 at 2:17 PM, Sakari Ailus wrote: > Felipe Balbi wrote: >> Hi, >> >> On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote: >>> Hello Felipe, >>> >>> in include/linux/wait.h >>> >>> #define wake_up(x)            __wake_up(x, TASK_NORMAL, 1, NULL) >>

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-19 Thread Felipe Balbi
Hi, On Sat, Feb 19, 2011 at 01:35:09PM +0200, David Cohen wrote: > >> aha, now I get it, so shouldn't the real fix be including > >> on , I mean, it's who uses a symbol > >> defined in , right ? > > That's a tricky situation. linux/sched.h includes indirectly > linux/completion.h which includes

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-19 Thread David Cohen
On Sat, Feb 19, 2011 at 5:00 PM, Felipe Balbi wrote: > Hi, > > On Sat, Feb 19, 2011 at 01:35:09PM +0200, David Cohen wrote: >> >> aha, now I get it, so shouldn't the real fix be including >> >> on , I mean, it's who uses a symbol >> >> defined in , right ? >> >> That's a tricky situation. linux/

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-20 Thread Felipe Balbi
Hi, On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: > > I have to disagree. The fundamental problem is the circular dependency > > between those two files: > > > > sched.h uses wait_queue_head_t defined in wait.h > > wait.h uses TASK_* defined in sched.h > > > > So, IMO the real fix w

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi wrote: > Hi, > > On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: >> > I have to disagree. The fundamental problem is the circular dependency >> > between those two files: >> > >> > sched.h uses wait_queue_head_t defined in wait.h >> > wait

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-21 Thread Felipe Balbi
On Mon, Feb 21, 2011 at 02:09:07PM +0200, David Cohen wrote: > On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi wrote: > > Hi, > > > > On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: > >> > I have to disagree. The fundamental problem is the circular dependency > >> > between those two fi

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-24 Thread David Cohen
On Mon, Feb 21, 2011 at 2:21 PM, Felipe Balbi wrote: > On Mon, Feb 21, 2011 at 02:09:07PM +0200, David Cohen wrote: >> On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi wrote: >> > Hi, >> > >> > On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: >> >> > I have to disagree. The fundamental p

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-24 Thread Thomas Weber
Hallo David, Am 25.02.2011 00:36, schrieb David Cohen: > On Mon, Feb 21, 2011 at 2:21 PM, Felipe Balbi wrote: >> On Mon, Feb 21, 2011 at 02:09:07PM +0200, David Cohen wrote: >>> On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi wrote: Hi, On Sat, Feb 19, 2011 at 06:04:58PM +0200, Davi

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-07 Thread Randy Dunlap
On Mon, 7 Feb 2011 09:49:07 +0100 Thomas Weber wrote: > Add linux/sched.h because of missing declaration of TASK_NORMAL. > > This patch fixes the following error: > > drivers/media/video/omap24xxcam.c: In function > 'omap24xxcam_vbq_complete': > drivers/media/video/omap24xxcam.c:415: error: 'TA

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Sakari Ailus
Thomas Weber wrote: > Add linux/sched.h because of missing declaration of TASK_NORMAL. > > This patch fixes the following error: > > drivers/media/video/omap24xxcam.c: In function > 'omap24xxcam_vbq_complete': > drivers/media/video/omap24xxcam.c:415: error: 'TASK_NORMAL' undeclared > (first use i

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Felipe Balbi
On Tue, Feb 15, 2011 at 01:28:19PM +0200, Sakari Ailus wrote: > Thomas Weber wrote: > > Add linux/sched.h because of missing declaration of TASK_NORMAL. > > > > This patch fixes the following error: > > > > drivers/media/video/omap24xxcam.c: In function > > 'omap24xxcam_vbq_complete': > > drivers

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Sylwester Nawrocki
Hi Felipe, On 02/15/2011 12:37 PM, Felipe Balbi wrote: > On Tue, Feb 15, 2011 at 01:28:19PM +0200, Sakari Ailus wrote: >> Thomas Weber wrote: >>> Add linux/sched.h because of missing declaration of TASK_NORMAL. >>> >>> This patch fixes the following error: >>> >>> drivers/media/video/omap24xxcam.c

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Felipe Balbi
hi, On Tue, Feb 15, 2011 at 12:44:42PM +0100, Sylwester Nawrocki wrote: > > Are we using the same tree ? I don't see anything related to TASK_* on > > Please have a look at definition of macro wake_up. This where those > TASK_* flags are used. $ git grep -e TASK_ drivers/media/video/omap*.[ch] $

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Thomas Weber
Am 15.02.2011 12:44, schrieb Sylwester Nawrocki: > Hi Felipe, > > On 02/15/2011 12:37 PM, Felipe Balbi wrote: >> On Tue, Feb 15, 2011 at 01:28:19PM +0200, Sakari Ailus wrote: >>> Thomas Weber wrote: Add linux/sched.h because of missing declaration of TASK_NORMAL. This patch fixes the

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Sakari Ailus
Felipe Balbi wrote: > hi, > > On Tue, Feb 15, 2011 at 12:44:42PM +0100, Sylwester Nawrocki wrote: >>> Are we using the same tree ? I don't see anything related to TASK_* on >> >> Please have a look at definition of macro wake_up. This where those >> TASK_* flags are used. > > $ git grep -e TASK_

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Felipe Balbi
Hi, On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote: > Hello Felipe, > > in include/linux/wait.h > > #define wake_up(x)__wake_up(x, TASK_NORMAL, 1, NULL) aha, now I get it, so shouldn't the real fix be including on , I mean, it's who uses a symbol defined in , right ?

Re: [PATCH resend] video: omap24xxcam: Fix compilation

2011-02-15 Thread Sakari Ailus
Felipe Balbi wrote: > Hi, > > On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote: >> Hello Felipe, >> >> in include/linux/wait.h >> >> #define wake_up(x)__wake_up(x, TASK_NORMAL, 1, NULL) > > aha, now I get it, so shouldn't the real fix be including > on , I mean, it's who