Re: [PATCH v2] ARM: omap2: throw the die id into the entropy pool

2013-10-03 Thread Tony Lindgren
* Linus Walleij [130910 01:28]: > On Mon, Sep 9, 2013 at 9:14 PM, Paul Walmsley wrote: > > > Heh, that function name "add_device_randomness()" is a bit misleading. > > It's not actually intended to add "randomness": from > > drivers/char/random.c: > > Yeah you're right... > > Tony feel free to

Re: [PATCH v2] ARM: omap2: throw the die id into the entropy pool

2013-09-10 Thread Linus Walleij
On Mon, Sep 9, 2013 at 9:14 PM, Paul Walmsley wrote: > Heh, that function name "add_device_randomness()" is a bit misleading. > It's not actually intended to add "randomness": from > drivers/char/random.c: Yeah you're right... Tony feel free to edit the commit message when applying. > * None

Re: [PATCH v2] ARM: omap2: throw the die id into the entropy pool

2013-09-09 Thread Paul Walmsley
By the way, if anyone wants to expand on Linus' patch for OMAP, there are several other register fields that could be mixed in, which, based on their names, might vary on a per-chip basis. For example, on OMAP4, the CONTROL_STD_FUSE_OPP* and CONTROL_DPLL_NWELL_TRIM* registers. - Paul -- To

Re: [PATCH v2] ARM: omap2: throw the die id into the entropy pool

2013-09-09 Thread Paul Walmsley
Hi Linus, On Thu, 5 Sep 2013, Linus Walleij wrote: > Atleast eight bytes of this number are totally unique for the device > it seems, so this is a perfect candidate for feeding the entropy > pool. One byte more or less of constants does not matter so feed in > the entire OID struct. > > Cc: Theo

[PATCH v2] ARM: omap2: throw the die id into the entropy pool

2013-09-05 Thread Linus Walleij
Atleast eight bytes of this number are totally unique for the device it seems, so this is a perfect candidate for feeding the entropy pool. One byte more or less of constants does not matter so feed in the entire OID struct. Cc: Theodore Ts'o Cc: Paul Walmsley Reviewed-by: Kevin Hilman Signed-o