Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-04 Thread Grant Likely
On Mon, Oct 03, 2011 at 11:34:34AM -0600, Paul Walmsley wrote: + devicetree-discuss, lkml On Mon, 3 Oct 2011, Cousson, Benoit wrote: But at that time, device tree was not there... Now, the whole dev_attr stuff will be replaced because device tree is able to provide the driver any

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-03 Thread Tomi Valkeinen
Hi Paul, On Sun, 2011-10-02 at 22:45 -0600, Paul Walmsley wrote: Hi some comments: On Mon, 12 Sep 2011, Archit Taneja wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-03 Thread Cousson, Benoit
Hi Tomi, On 10/3/2011 10:21 AM, Valkeinen, Tomi wrote: Hi Paul, On Sun, 2011-10-02 at 22:45 -0600, Paul Walmsley wrote: [...] +struct omap_dss_dispc_dev_attr { + u8 manager_count; + boolhas_framedonetv_irq; +}; + +#endif diff --git

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-03 Thread Paul Walmsley
Hi Tomi, On Mon, 3 Oct 2011, Tomi Valkeinen wrote: On Sun, 2011-10-02 at 22:45 -0600, Paul Walmsley wrote: On Mon, 12 Sep 2011, Archit Taneja wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-03 Thread Paul Walmsley
+ devicetree-discuss, lkml On Mon, 3 Oct 2011, Cousson, Benoit wrote: But at that time, device tree was not there... Now, the whole dev_attr stuff will be replaced because device tree is able to provide the driver any kind of custom information that can be retrieved directly from the driver

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-03 Thread Paul Walmsley
Hi Archit, thanks for the quick and informative response - On Mon, 3 Oct 2011, Archit Taneja wrote: On Monday 03 October 2011 10:15 AM, Paul Walmsley wrote: On Mon, 12 Sep 2011, Archit Taneja wrote: diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-02 Thread Paul Walmsley
Hi some comments: On Mon, 12 Sep 2011, Archit Taneja wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot reset the DISPC module just like that, but the outputs need to be

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-02 Thread Archit Taneja
Hi Paul, On Monday 03 October 2011 10:15 AM, Paul Walmsley wrote: Hi some comments: On Mon, 12 Sep 2011, Archit Taneja wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-09-20 Thread Archit Taneja
Hi Paul, On Monday 12 September 2011 12:38 PM, Taneja, Archit wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot reset the DISPC module just like that, but the outputs need to

[PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-09-12 Thread Archit Taneja
Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot reset the DISPC module just like that, but the outputs need to be disabled first. Add function dispc_disable_outputs() which disables