Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-09 Thread Samuel Ortiz
Hi Roger, On Fri, Oct 09, 2009 at 03:32:12PM +0300, Roger Quadros wrote: > Hi Samuel, > > What is the status of this patch? > Without this patch we are unable to boot on systems using musb usb controller. I'm applying that patch to my for-next branch. And I will also try to have Linus pulling it

Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-09 Thread Roger Quadros
Hi, I just observed that this patch does not work as intended with 2.6.31.3 It seems that twl4030_usb_probe() and hence twl4030_usb_ldo_init() is called before the required regulators have been 'linked' to the device in twl4030-core.c, thus causing regulator_get(twl->dev, "usb3v1"); to fail, a

Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-09 Thread Roger Quadros
Hi Samuel, What is the status of this patch? Without this patch we are unable to boot on systems using musb usb controller. cheers, -roger. On Thu, Oct 1, 2009 at 11:25 AM, Roger Quadros wrote: > The usb regulator supplies (usb1v5, usb1v8 & usb3v1) must be available > before adding the twl4030_

Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-01 Thread Roger Quadros
Artem Bityutskiy wrote: On Thu, 2009-10-01 at 11:25 +0300, Roger Quadros wrote: if (twl_has_bci() && pdata->bci && !(features & TPS_SUBSET)) { child = add_child(3, "twl4030_bci", @@ -532,16 +531,61 @@ add_children(struct twl4030_platform_data *pdata, unsigned long featur

Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-01 Thread Artem Bityutskiy
On Thu, 2009-10-01 at 11:25 +0300, Roger Quadros wrote: > if (twl_has_bci() && pdata->bci && !(features & TPS_SUBSET)) { > child = add_child(3, "twl4030_bci", > @@ -532,16 +531,61 @@ add_children(struct twl4030_platform_data *pdata, > unsigned long features) > } > >

[PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled

2009-10-01 Thread Roger Quadros
The usb regulator supplies (usb1v5, usb1v8 & usb3v1) must be available before adding the twl4030_usb child, else twl4030_usb_ldo_init() will always fail thus causing boot lock-up. This patch fixes boot on OMAP systems using the twl4030 usb transceiver. CONFIG_TWL4030_USB=y Signed-off-by: Roger Qu