Re: [PATCH v2 08/21] irqchip: crossbar: convert dra7 crossbar to stacked domains

2015-01-10 Thread Marc Zyngier
On 2015-01-08 14:39, Nishanth Menon wrote: On 17:42-20150107, Marc Zyngier wrote: [..] diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 10b725c..048cfeb 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -423,7 +423,7 @@

Re: [PATCH v2 08/21] irqchip: crossbar: convert dra7 crossbar to stacked domains

2015-01-08 Thread Nishanth Menon
On 17:42-20150107, Marc Zyngier wrote: a few more minor comments follow: [..] > --- a/drivers/irqchip/irq-crossbar.c > +++ b/drivers/irqchip/irq-crossbar.c [..] > @@ -33,6 +34,7 @@ > * @write: register write function pointer > */ > struct crossbar_device { > + raw_spinlock_t lock; ^^ ker

Re: [PATCH v2 08/21] irqchip: crossbar: convert dra7 crossbar to stacked domains

2015-01-08 Thread Nishanth Menon
On 17:42-20150107, Marc Zyngier wrote: [..] > diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts > index 10b725c..048cfeb 100644 > --- a/arch/arm/boot/dts/dra7-evm.dts > +++ b/arch/arm/boot/dts/dra7-evm.dts > @@ -423,7 +423,7 @@ > status = "okay"; > pinctrl-nam

[PATCH v2 08/21] irqchip: crossbar: convert dra7 crossbar to stacked domains

2015-01-07 Thread Marc Zyngier
Support for the TI crossbar used on the DRA7 family of chips is implemented as an ugly hack on the side of the GIC. Converting it to stacked domains makes it slightly more palatable, as it results in a cleanup. Unfortunately, as the DT bindings failed to acknowledge the fact that this is actually