Re: [PATCH v2 1/2] arm: a driver for on-chip ETM and ETB

2009-10-19 Thread Linus Walleij
2009/10/19 Alexander Shishkin : > That said, I'm personally not overly concerned about the support for > earlier versions of those macrocells and if you maintain that those > are better off implemented as AMBA drivers, I've not problem doing > that. If people are using older versions, they can ha

Re: [PATCH v2 1/2] arm: a driver for on-chip ETM and ETB

2009-10-19 Thread Alexander Shishkin
2009/10/13 Russell King - ARM Linux : > On Tue, Oct 13, 2009 at 08:06:50PM +0300, Alexander Shishkin wrote: >> Changes: >> v2 -- major update: >>       * fixes according to comments from Linus Walleij and Anand Gadiyar >>       * omap3 clock-related stuff moved to platform device > > And so what ab

Re: [PATCH v2 1/2] arm: a driver for on-chip ETM and ETB

2009-10-13 Thread Russell King - ARM Linux
On Tue, Oct 13, 2009 at 08:06:50PM +0300, Alexander Shishkin wrote: > + emu_clk = *(struct clk **)pdev->dev.platform_data; > + if (emu_clk) > + clk_enable(emu_clk); > + Definitely no way this is going to be acceptable. Never EVER pass clk pointers around like this. And you've

Re: [PATCH v2 1/2] arm: a driver for on-chip ETM and ETB

2009-10-13 Thread Russell King - ARM Linux
On Tue, Oct 13, 2009 at 08:06:50PM +0300, Alexander Shishkin wrote: > Changes: > v2 -- major update: > * fixes according to comments from Linus Walleij and Anand Gadiyar > * omap3 clock-related stuff moved to platform device And so what about my comments? -- To unsubscribe from this li

[PATCH v2 1/2] arm: a driver for on-chip ETM and ETB

2009-10-13 Thread Alexander Shishkin
This driver implements support for on-chip Embedded Tracing Macrocell and Embedded Trace Buffer. It allows to trigger tracing of kernel execution flow and exporting trace output to userspace via character device and a sysrq combo. Trace output can then be decoded by a fairly simple open source too