[PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |1 + drivers/usb/gadget/Kconfig |3 +-- drivers/usb/musb/Kconfig |6 ++ drivers/usb/otg/Kcon

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Tony Lindgren
* Felipe Contreras [101019 13:43]: > On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: > > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras > > wrote: > >> There are two parts, one part is to fix the Kconfigs, and another was > >> to come up with a way to replace the horrible defconfigs.

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Kevin Hilman
Tony Lindgren writes: > * Felipe Contreras [101019 13:43]: >> On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: >> > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras >> > wrote: >> >> There are two parts, one part is to fix the Kconfigs, and another was >> >> to come up with a way to re

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Tony Lindgren
* Kevin Hilman [101019 17:04]: > Tony Lindgren writes: > > > > This actually produces a booting omap2+ kernel with no .config > > at all. I've tested it with: > > > > $ echo CONFIG_ARCH_OMAP=y > .config > > $ yes "" | ARCH=arm make oldconfig > > > > So if you have something that's needed on almos

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 07:13:07PM -0500, Kevin Hilman wrote: One thing I don't like about this is that there is currently no way to 'select' as a module. Yeah, I remember suggesting to add "module" to Kconfig language which would do the job of selecting as module. -- balbi -- To unsubscr

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Roger Quadros
On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: Hi Roger, On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros wrote: @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE config USB_G_NOKIA tristate "Nokia composite gadget" depends on PHONET + depends on USB_GADGET_MUSB_HDRC Th

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Balbi
On Wed, Oct 20, 2010 at 02:46:49AM -0500, Roger Quadros wrote: On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: Hi Roger, On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros wrote: @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE config USB_G_NOKIA tristate "Nokia composite gadget"

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread felipe.contre...@gmail.com
On Wed, Oct 20, 2010 at 3:13 AM, Kevin Hilman wrote: > Tony Lindgren writes: >> So if you have something that's needed on almost every omap, >> you can select it there. > > One thing I don't like about this is that there is currently no way to > 'select' as a module. > > In order to get to a mini

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread felipe.contre...@gmail.com
On Wed, Oct 20, 2010 at 10:46 AM, Roger Quadros wrote: > On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: >> On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros >>  wrote: @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE  config USB_G_NOKIA        tristate "Nokia composite gadget" >>

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Roger Quadros
On 10/20/2010 11:53 AM, ext felipe.contre...@gmail.com wrote: On Wed, Oct 20, 2010 at 10:46 AM, Roger Quadros wrote: On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros wrote: @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE config USB_G_NOKIA

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadros wrote: > On 10/20/2010 11:53 AM, ext felipe.contre...@gmail.com wrote: >> >> On Wed, Oct 20, 2010 at 10:46 AM, Roger Quadros >>  wrote: >>> >>> On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadr

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Roger Quadros
On 10/20/2010 12:23 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadros wrote: On 10/20/2010 11:53 AM, ext felipe.contre...@gmail.com wrote: On Wed, Oct 20, 2010 at 10:46 AM, Roger Quadros wrote: On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: On Tue, Oct

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Roger Quadros
On 10/20/2010 12:23 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadros wrote: On 10/20/2010 11:53 AM, ext felipe.contre...@gmail.com wrote: On Wed, Oct 20, 2010 at 10:46 AM, Roger Quadros wrote: On 10/19/2010 05:33 PM, ext Felipe Contreras wrote: On Tue, Oct

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Balbi
On Wed, Oct 20, 2010 at 04:23:13AM -0500, Felipe Contreras wrote: Ok, but USB_OMAP is not supposed to work on the N900? (I tried and it didn't) h, that's old. That's from the omap1. It's the old omap_udc.c I don't think so, because people might not want USB at all. The ideal case would be

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 3:33 PM, Roger Quadros wrote: > On 10/20/2010 12:23 PM, ext Felipe Contreras wrote: >> On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadros >>  wrote: >>> USB_G_NOKIA just needs a USB gadget controller to work. The gadget >>> controller used for the board should come from the bo

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 3:54 PM, Felipe Balbi wrote: > On Wed, Oct 20, 2010 at 04:23:13AM -0500, Felipe Contreras wrote: >> >> Ok, but USB_OMAP is not supposed to work on the N900? (I tried and it >> didn't) > > h, that's old. That's from the omap1. It's the old omap_udc.c Ok, then the depend

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Balbi
hi, On Wed, Oct 20, 2010 at 09:52:06AM -0500, Felipe Contreras wrote: TWL4030_USB is inside drivers/usb/Kconfig and drivers/usb/otg/Kconfig, which means in order to achieve the same on the board config you would have to do: default y if USB_SUPPORT && (USB || USB_GADGET) && ARCH_OMAP3 Seems to

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 6:15 PM, Felipe Balbi wrote: > On Wed, Oct 20, 2010 at 09:52:06AM -0500, Felipe Contreras wrote: >> >> TWL4030_USB is inside drivers/usb/Kconfig and drivers/usb/otg/Kconfig, >> which means in order to achieve the same on the board config you would >> have to do: >> >> defau

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-20 Thread Felipe Balbi
Hi, On Wed, Oct 20, 2010 at 11:22:17AM -0500, Felipe Contreras wrote: Users would not need to care... if they enable USB and USB_GADGET, it will be selected automatically for OMAP3, which is what users would expect. wouldn't a user expect USB to be enabled if the board _has_ a USB connector ?

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 8:54 PM, Felipe Balbi wrote: > On Wed, Oct 20, 2010 at 11:22:17AM -0500, Felipe Contreras wrote: >> >> Users would not need to care... if they enable USB and USB_GADGET, it >> will be selected automatically for OMAP3, which is what users would >> expect. > > wouldn't a user

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Balbi
hi, On Thu, Oct 21, 2010 at 04:04:27AM -0500, Felipe Contreras wrote: wouldn't a user expect USB to be enabled if the board _has_ a USB connector ? Not if it's not going to be used. and how would you know before hand if it's going to be used or not ? 1) Do you think all the OMAP3 boards sh

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Contreras
Hi, On Thu, Oct 21, 2010 at 1:24 PM, Felipe Balbi wrote: > On Thu, Oct 21, 2010 at 04:04:27AM -0500, Felipe Contreras wrote: >>> >>> wouldn't a user expect USB to be enabled if the board _has_ a USB >>> connector ? >> >> Not if it's not going to be used. > > and how would you know before hand if

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Roger Quadros
Hi, On 10/20/2010 05:38 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 3:33 PM, Roger Quadros wrote: On 10/20/2010 12:23 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadros wrote: USB_G_NOKIA just needs a USB gadget controller to work. The gadget contro

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Balbi
Hi, On Thu, Oct 21, 2010 at 09:07:59AM -0500, Roger Quadros wrote: But I'm not sure that omap_udc is used only for OMAP1 architecture. Dave/Tony should confirm this. Maybe the old omap2420_h4 board still uses it, but from 2430 I think the ip isn't even there anymore. -- balbi -- To unsubscrib

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Tony Lindgren
* Felipe Balbi [101021 08:32]: > Hi, > > On Thu, Oct 21, 2010 at 09:07:59AM -0500, Roger Quadros wrote: > >But I'm not sure that omap_udc is used only for OMAP1 architecture. > >Dave/Tony should confirm this. > > Maybe the old omap2420_h4 board still uses it, but from 2430 I think the > ip isn't

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 05:03:28AM -0500, Felipe Contreras wrote: + depends on (NOP_USB_XCEIV || TWL4030_USB) + default y if ARCH_OMAP3 + default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN it could be only me, but I see these kind of dependencies tend to disaster. The

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 1:32 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 05:03:28AM -0500, Felipe Contreras wrote: >> >> +       depends on (NOP_USB_XCEIV || TWL4030_USB) >> +       default y if ARCH_OMAP3 >> +       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN > > it could be only

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 05:59:58AM -0500, Felipe Contreras wrote: The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is already there, I'm just making it explicit. The rest are not dependencies, just sensible defaults, and they are already in drivers/usb/musb/Kconfig, I'm just movi

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 2:16 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 05:59:58AM -0500, Felipe Contreras wrote: >> >> The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is >> already there, I'm just making it explicit. The rest are not >> dependencies, just sensible defaults, an

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 06:36:32AM -0500, Felipe Contreras wrote: That is actually the intention. so it's a bit messed up one :-p It's the other way around. He wanted to get rid of defconfigs completely by moving the complexity to Kconfigs: Yes, but he was suggesting to add things like

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Roger Quadros
Hi Felipe, On 10/19/2010 01:03 PM, ext Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |1 + drivers/usb/gadget/Kconfig |3

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 2:52 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 06:36:32AM -0500, Felipe Contreras wrote: >> >> That is actually the intention. > > so it's a bit messed up one :-p Why? It makes configurations simpler. >> It's the other way around. He wanted to get rid of defconfig

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
Hi Roger, On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros wrote: >> @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE >>  config USB_G_NOKIA >>        tristate "Nokia composite gadget" >>        depends on PHONET >> +       depends on USB_GADGET_MUSB_HDRC > > This is wrong. Is there a build problem or

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, (already at home so using personal email) On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras wrote: > There are two parts, one part is to fix the Kconfigs, and another was > to come up with a way to replace the horrible defconfigs. Part two is > mostly fixed thanks to 'make savedefconfig',

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: > Add missing dependencies, and remove redundant ones, and select sensible > defaults. > > Signed-off-by: Felipe Contreras > --- > drivers/mfd/Kconfig|3 ++- > drivers/regulator/Kconfig |1 + > drivers/usb/gadget/

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Anand Gadiyar
On 10/19/2010 9:22 PM, Greg KH wrote: On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 09:42:17PM +0530, Anand Gadiyar wrote: > On 10/19/2010 9:22 PM, Greg KH wrote: > >On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: > >>Add missing dependencies, and remove redundant ones, and select sensible > >>defaults. > >> > >>Signed-off-by: Felipe Contr

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Kevin Hilman
Anand Gadiyar writes: > On 10/19/2010 9:22 PM, Greg KH wrote: >> On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: >>> Add missing dependencies, and remove redundant ones, and select sensible >>> defaults. >>> >>> Signed-off-by: Felipe Contreras >>> --- >>> drivers/mfd/Kconfig

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras > wrote: >> There are two parts, one part is to fix the Kconfigs, and another was >> to come up with a way to replace the horrible defconfigs. Part two is >> mostly fixed thanks to 'make sa