Re: [PATCH v3 03/13] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros

2011-07-07 Thread Paul Walmsley
On Fri, 1 Jul 2011, Benoit Cousson wrote: The CLKCTRL register was accessed using an absolute address. The usage of hardcoded macros to calculate virtual address from physical one should be avoided as much as possible. The usage of a offset will allow future improvement like migration from

Re: [PATCH v3 03/13] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros

2011-07-07 Thread Todd Poynor
On Thu, Jul 07, 2011 at 02:25:23AM -0600, Paul Walmsley wrote: On Fri, 1 Jul 2011, Benoit Cousson wrote: The CLKCTRL register was accessed using an absolute address. The usage of hardcoded macros to calculate virtual address from physical one should be avoided as much as possible. The

Re: [PATCH v3 03/13] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros

2011-07-07 Thread Paul Walmsley
Hi Todd, On Thu, 7 Jul 2011, Todd Poynor wrote: On Thu, Jul 07, 2011 at 02:25:23AM -0600, Paul Walmsley wrote: -int omap4_cm_wait_module_ready(void __iomem *clkctrl_reg) +int omap4_cminst_wait_module_ready(u8 part, u16 inst, s16 cdoffs, u16 clkctrl_offs) { int i = 0; -

Re: [PATCH v3 03/13] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros

2011-07-07 Thread Paul Walmsley
By the way, here's the updated patch. - Paul From b37411ec382d013d229b199780b06b584a929a3a Mon Sep 17 00:00:00 2001 From: Benoit Cousson b-cous...@ti.com Date: Fri, 1 Jul 2011 23:09:08 +0200 Subject: [PATCH] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros The CLKCTRL