Re: [PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-02 Thread Vivek Gautam
Hi Balbi, On Tue, Apr 2, 2013 at 2:02 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote: >> +#else >> +#define dwc3_runtime_suspend NULL >> +#define dwc3_runtime_resume NULL > > this #else branch is unnecessary. Look at the definition

Re: [PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-02 Thread Felipe Balbi
Hi, On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote: > +#else > +#define dwc3_runtime_suspend NULL > +#define dwc3_runtime_resume NULL this #else branch is unnecessary. Look at the definition for SET_RUNTIME_PM_OPS() -- balbi signature.asc Description: Digital si

[PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-01 Thread Vivek Gautam
Right now it doesn't handle full runtime suspend/resume functionality. However it allows to handle PHYs' sleep and wakeup across runtime suspend/resume. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 43 +++ 1 files changed, 43 insertions(+),