Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-16 Thread Mathias Nyman
On 15.02.2015 16:29, Sneeker Yeh wrote: > hi Mathias: > > thanks for reviewing these patch, > and sorry for replying lately~ > >>> + status = readl(port_array[dev_port_num - 1]); >>> + >>> + /* write 1 to clear */ >>> + if (!(status & PORT_CONNECT) && (status & PORT_CSC)) >>> +

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-15 Thread Sneeker Yeh
Hi Alan: thanks for comment it, and sorry that a little bit late for replying, 2015-02-12 23:18 GMT+08:00 Alan Stern : > On Thu, 12 Feb 2015, Mathias Nyman wrote: > >> On 25.01.2015 10:13, Sneeker Yeh wrote: >> > This issue is defined by a three-way race at disconnect, between >> > 1) Class drive

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-15 Thread Sneeker Yeh
hi Mathias: thanks for reviewing these patch, and sorry for replying lately~ 2015-02-12 21:50 GMT+08:00 Mathias Nyman : > On 25.01.2015 10:13, Sneeker Yeh wrote: >> This issue is defined by a three-way race at disconnect, between >> 1) Class driver interrupt endpoint resheduling attempts if the I

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-13 Thread Mathias Nyman
On 25.01.2015 10:13, Sneeker Yeh wrote: Oh, and one more thing: > > +static void xhci_try_to_clear_csc(struct usb_hcd *hcd, int dev_port_num) > +{ > + int max_ports; > + struct xhci_hcd *xhci = hcd_to_xhci(hcd); > + __le32 __iomem **port_array; > + u32 status; > + > + /* pri

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-13 Thread Mathias Nyman
On 12.02.2015 17:18, Alan Stern wrote: > On Thu, 12 Feb 2015, Mathias Nyman wrote: > >> On 25.01.2015 10:13, Sneeker Yeh wrote: >>> This issue is defined by a three-way race at disconnect, between >>> 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an >>> ep >>>error e

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-12 Thread Alan Stern
On Thu, 12 Feb 2015, Mathias Nyman wrote: > On 25.01.2015 10:13, Sneeker Yeh wrote: > > This issue is defined by a three-way race at disconnect, between > > 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an > > ep > >error event due to device detach (it would try 3 ti

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-12 Thread Mathias Nyman
On 25.01.2015 10:13, Sneeker Yeh wrote: > This issue is defined by a three-way race at disconnect, between > 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an ep >error event due to device detach (it would try 3 times) > 2) Disconnect interrupt on PORTSC_CSC, which is c

[PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-01-25 Thread Sneeker Yeh
This issue is defined by a three-way race at disconnect, between 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an ep error event due to device detach (it would try 3 times) 2) Disconnect interrupt on PORTSC_CSC, which is cleared by hub thread asynchronously 3) The ha