Re: [PATCH v3 13/13] gpio/omap: fix incorrect update to context.irqenable1

2012-03-12 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: In _enable_gpio_irqbank() when bank-regs-set_irqenable is valid, gpio_mask can be directly set by writing to set_irqenable register without overwriting current value. Ouch. Nice catch. In order to ensure the same is stored in

Re: [PATCH v3 13/13] gpio/omap: fix incorrect update to context.irqenable1

2012-03-12 Thread DebBarma, Tarun Kanti
On Tue, Mar 13, 2012 at 3:39 AM, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: In _enable_gpio_irqbank() when bank-regs-set_irqenable is valid, gpio_mask can be directly set by writing to set_irqenable register without overwriting current value. Ouch.  

[PATCH v3 13/13] gpio/omap: fix incorrect update to context.irqenable1

2012-03-07 Thread Tarun Kanti DebBarma
In _enable_gpio_irqbank() when bank-regs-set_irqenable is valid, gpio_mask can be directly set by writing to set_irqenable register without overwriting current value. In order to ensure the same is stored in context.irqenable1, we must read from regs-irqenable instead of overwriting it with

Re: [PATCH v3 13/13] gpio/omap: fix incorrect update to context.irqenable1

2012-03-07 Thread Santosh Shilimkar
On Wednesday 07 March 2012 12:16 PM, Tarun Kanti DebBarma wrote: In _enable_gpio_irqbank() when bank-regs-set_irqenable is valid, gpio_mask can be directly set by writing to set_irqenable register without overwriting current value. In order to ensure the same is stored in context.irqenable1,