Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread Tony Lindgren
* Tony Lindgren [110224 12:29]: > * Guzman Lugo, Fernando [110224 09:56]: > > On Thu, Feb 24, 2011 at 5:29 AM, Felipe Balbi wrote: > > > On Thu, Feb 24, 2011 at 01:26:05PM +0200, David Cohen wrote: > > >> On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi wrote: > > >> > > >> This patch is already

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread Tony Lindgren
* Guzman Lugo, Fernando [110224 09:56]: > On Thu, Feb 24, 2011 at 5:29 AM, Felipe Balbi wrote: > > On Thu, Feb 24, 2011 at 01:26:05PM +0200, David Cohen wrote: > >> On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi wrote: > >> > >> This patch is already acked. What about leave it as it is and discu

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread Guzman Lugo, Fernando
On Thu, Feb 24, 2011 at 5:29 AM, Felipe Balbi wrote: > On Thu, Feb 24, 2011 at 01:26:05PM +0200, David Cohen wrote: >> On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi wrote: >> > Hi, >> > >> > On Wed, Feb 23, 2011 at 10:09:05PM +0200, Sakari Ailus wrote: >> >> > In OMAP4 the cortex M3 is a double

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread Felipe Balbi
On Thu, Feb 24, 2011 at 01:26:05PM +0200, David Cohen wrote: > On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Feb 23, 2011 at 10:09:05PM +0200, Sakari Ailus wrote: > >> > In OMAP4 the cortex M3 is a double core processor and as each core is > >> > running they own ve

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread David Cohen
On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi wrote: > Hi, > > On Wed, Feb 23, 2011 at 10:09:05PM +0200, Sakari Ailus wrote: >> > In OMAP4 the cortex M3 is a double core processor and as each core is >> > running they own version of the RTOS we threat them independently. So >> > our driver which

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-24 Thread Felipe Balbi
Hi, On Wed, Feb 23, 2011 at 10:09:05PM +0200, Sakari Ailus wrote: > > In OMAP4 the cortex M3 is a double core processor and as each core is > > running they own version of the RTOS we threat them independently. So > > our driver which controls the remote processor sees two processor but > > both u

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread David Cohen
On Wed, Feb 23, 2011 at 11:48 PM, Guzman Lugo, Fernando wrote: > On Wed, Feb 23, 2011 at 2:56 PM, Sakari Ailus > wrote: >> David Cohen wrote: >>> On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando >>> wrote: On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: > On Wed, Feb 23, 2011

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Guzman Lugo, Fernando
On Wed, Feb 23, 2011 at 2:56 PM, Sakari Ailus wrote: > David Cohen wrote: >> On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando >> wrote: >>> On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando wrote: > On Wed, Feb 16, 201

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Guzman Lugo, Fernando
On Wed, Feb 23, 2011 at 2:09 PM, Sakari Ailus wrote: > Guzman Lugo, Fernando wrote: >> Hi, > > Hi Fernando, > >> In OMAP4 the cortex M3 is a double core processor and as each core is >> running they own version of the RTOS we threat them independently. So >> our driver which controls the remote pr

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Guzman Lugo, Fernando
On Wed, Feb 23, 2011 at 1:54 PM, David Cohen wrote: > On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando > wrote: >> On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: >>> On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando >>> wrote: On Wed, Feb 16, 2011 at 1:35 PM, David Cohen w

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Sakari Ailus
David Cohen wrote: > On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando > wrote: >> On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: >>> On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando >>> wrote: On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: > Add support to registe

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread David Cohen
On Wed, Feb 23, 2011 at 10:09 PM, Sakari Ailus wrote: > Guzman Lugo, Fernando wrote: >> Hi, > > Hi Fernando, > >> In OMAP4 the cortex M3 is a double core processor and as each core is >> running they own version of the RTOS we threat them independently. So >> our driver which controls the remote p

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Sakari Ailus
Guzman Lugo, Fernando wrote: > Hi, Hi Fernando, > In OMAP4 the cortex M3 is a double core processor and as each core is > running they own version of the RTOS we threat them independently. So > our driver which controls the remote processor sees two processor but > both use the same iommu hw. Whe

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread David Cohen
On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando wrote: > On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: >> On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando >> wrote: >>> On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: Add support to register an isr for IOMMU fault sit

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread Guzman Lugo, Fernando
On Wed, Feb 23, 2011 at 3:45 AM, David Cohen wrote: > On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando > wrote: >> On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: >>> Add support to register an isr for IOMMU fault situations and adapt it >>> to allow such (*isr)() to be used as fault c

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-23 Thread David Cohen
On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando wrote: > On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: >> Add support to register an isr for IOMMU fault situations and adapt it >> to allow such (*isr)() to be used as fault callback. Drivers using IOMMU >> module might want to be info

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-22 Thread Guzman Lugo, Fernando
On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: > Add support to register an isr for IOMMU fault situations and adapt it > to allow such (*isr)() to be used as fault callback. Drivers using IOMMU > module might want to be informed when errors happen in order to debug it > or react. > > Signed-

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread David Cohen
On Tue, Feb 22, 2011 at 1:25 AM, Ramirez Luna, Omar wrote: > Hi, > > On Mon, Feb 21, 2011 at 3:12 PM, David Cohen wrote: >> Generic errors codes make easier to threat possible IOMMU users which >> have (partially or totally) common drivers for different OMAP >> versions. > > Agree then. Good we

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Ramirez Luna, Omar
Hi, On Mon, Feb 21, 2011 at 3:12 PM, David Cohen wrote: > Generic errors codes make easier to threat possible IOMMU users which > have (partially or totally) common drivers for different OMAP > versions. Agree then. >>> +       /* Fault callback or TLB/PTE Dynamic loading */ >>> +       if (obj

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 8:43 PM, Ramirez Luna, Omar wrote: > Hi, Hi, Thanks for the comments. > > On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: >> diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c >> index 49a1e5e..adb083e 100644 >> --- a/arch/arm/mach-omap2/iommu2

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Ramirez Luna, Omar
Hi, On Wed, Feb 16, 2011 at 1:35 PM, David Cohen wrote: > diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c > index 49a1e5e..adb083e 100644 > --- a/arch/arm/mach-omap2/iommu2.c > +++ b/arch/arm/mach-omap2/iommu2.c ... > >        da = iommu_read_reg(obj, MMU_FAULT_AD); >    

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Hiroshi DOYU
From: ext David Cohen Subject: Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling Date: Mon, 21 Feb 2011 11:07:01 +0200 > On Mon, Feb 21, 2011 at 10:18 AM, Hiroshi DOYU wrote: >> From: David Cohen >> Subject: [PATCH v3 2/2] OMAP: IOMMU: add supp

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Felipe Balbi
Hi, On Mon, Feb 21, 2011 at 10:57:45AM +0200, David Cohen wrote: > >> Ideally I'd like to avoid having "isr_priv" in iommu since it's not > >> used for iommu but client needs the place to pass its info to its > >> custom handler. Any better idea? > > > > I'm not sure if it makes sense as I don't k

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 10:18 AM, Hiroshi DOYU wrote: > From: David Cohen > Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault > handling > Date: Wed, 16 Feb 2011 21:35:51 +0200 > >> Add support to register an isr for IOMMU fault situations and adap

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 10:22 AM, Felipe Balbi wrote: > Hi, > > On Mon, Feb 21, 2011 at 10:18:56AM +0200, Hiroshi DOYU wrote: >> From: David Cohen >> Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault >> handling >> Date: Wed, 16 Fe

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Felipe Balbi
Hi, On Mon, Feb 21, 2011 at 10:18:56AM +0200, Hiroshi DOYU wrote: > From: David Cohen > Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault > handling > Date: Wed, 16 Feb 2011 21:35:51 +0200 > > > Add support to register an isr for IOMMU fault si

Re: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-21 Thread Hiroshi DOYU
From: David Cohen Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling Date: Wed, 16 Feb 2011 21:35:51 +0200 > Add support to register an isr for IOMMU fault situations and adapt it > to allow such (*isr)() to be used as fault callback. Drivers using IOMMU &g

[PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling

2011-02-16 Thread David Cohen
Add support to register an isr for IOMMU fault situations and adapt it to allow such (*isr)() to be used as fault callback. Drivers using IOMMU module might want to be informed when errors happen in order to debug it or react. Signed-off-by: David Cohen --- arch/arm/mach-omap2/iommu2.c