Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-04 Thread Luciano Coelho
On Wed, 2013-07-03 at 17:12 +0200, Javier Martinez Canillas wrote: > On Wed, Jul 3, 2013 at 4:15 PM, Luciano Coelho wrote: > > On Wed, 2013-07-03 at 17:03 +0300, Luciano Coelho wrote: > >> The platform_quirk element in the platform data was used to change the > >> way the IRQ is triggered. When s

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Sekhar Nori
On 7/3/2013 7:33 PM, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of hiding this irq flag setti

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Javier Martinez Canillas
On Wed, Jul 3, 2013 at 4:15 PM, Luciano Coelho wrote: > On Wed, 2013-07-03 at 17:03 +0300, Luciano Coelho wrote: >> The platform_quirk element in the platform data was used to change the >> way the IRQ is triggered. When set, the EDGE_IRQ quirk would change >> the irqflags used and treat edge tri

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Felipe Balbi
On Wed, Jul 03, 2013 at 05:18:14PM +0300, Luciano Coelho wrote: > On Wed, 2013-07-03 at 17:13 +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 03, 2013 at 05:03:23PM +0300, Luciano Coelho wrote: > > > diff --git a/arch/arm/mach-omap2/board-4430sdp.c > > > b/arch/arm/mach-omap2/board-4430sdp

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Felipe Balbi
Hi, On Wed, Jul 03, 2013 at 05:03:23PM +0300, Luciano Coelho wrote: > diff --git a/arch/arm/mach-omap2/board-4430sdp.c > b/arch/arm/mach-omap2/board-4430sdp.c > index 56a9a4f..953f620 100644 > --- a/arch/arm/mach-omap2/board-4430sdp.c > +++ b/arch/arm/mach-omap2/board-4430sdp.c > @@ -703,12 +703,

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Luciano Coelho
On Wed, 2013-07-03 at 17:13 +0300, Felipe Balbi wrote: > Hi, > > On Wed, Jul 03, 2013 at 05:03:23PM +0300, Luciano Coelho wrote: > > diff --git a/arch/arm/mach-omap2/board-4430sdp.c > > b/arch/arm/mach-omap2/board-4430sdp.c > > index 56a9a4f..953f620 100644 > > --- a/arch/arm/mach-omap2/board-443

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Luciano Coelho
On Wed, 2013-07-03 at 17:03 +0300, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of hiding this

[PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Luciano Coelho
The platform_quirk element in the platform data was used to change the way the IRQ is triggered. When set, the EDGE_IRQ quirk would change the irqflags used and treat edge trigger differently from the rest. Instead of hiding this irq flag setting behind the quirk, have the board files set the fla