RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-06-12 Thread Mohammed, Afzal
Hi Tony, On Tue, May 22, 2012 at 22:12:15, Tony Lindgren wrote: > for these cases. Otherwise we'll be breaking old boards with smsc911x > where the timings for the FPGA controlling smsc911x are unknown. Were you actually referring to sdp boards that work with smc91x driver using 91c96 ? Regards

Re: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-06-05 Thread Tony Lindgren
* Mohammed, Afzal [120525 03:20]: > Hi Tony, > > On Fri, May 25, 2012 at 12:56:59, Tony Lindgren wrote: > > * Paul Walmsley [120523 17:55]: > > > On Tue, 22 May 2012, Tony Lindgren wrote: > > > > > > > > Unfortunately for many of the older boards these values will probably > > > > remain unknow

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-25 Thread Mohammed, Afzal
Hi Tony, On Fri, May 25, 2012 at 12:56:59, Tony Lindgren wrote: > * Paul Walmsley [120523 17:55]: > > On Tue, 22 May 2012, Tony Lindgren wrote: > > > > > > Unfortunately for many of the older boards these values will probably > > > remain unknown. > > > > > > So the better approach here is to j

Re: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-25 Thread Tony Lindgren
* Paul Walmsley [120523 17:55]: > On Tue, 22 May 2012, Tony Lindgren wrote: > > > > Unfortunately for many of the older boards these values will probably > > remain unknown. > > > > So the better approach here is to just disable frequency scaling > > for these cases. Otherwise we'll be breaking

Re: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-23 Thread Paul Walmsley
On Tue, 22 May 2012, Tony Lindgren wrote: > * Paul Walmsley [120521 23:51]: > > > > Next, I'd suggest implementing the code to allow GPMC timing configuration > > from raw register data (the second method above). This is hackish but for > > some boards, this is all we'll have. This will also

Re: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-22 Thread Tony Lindgren
* Paul Walmsley [120521 23:51]: > > Next, I'd suggest implementing the code to allow GPMC timing configuration > from raw register data (the second method above). This is hackish but for > some boards, this is all we'll have. This will also presumably require > some extra DT bindings for the

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-22 Thread Mohammed, Afzal
Hi Paul, On Tue, May 22, 2012 at 12:17:30, Paul Walmsley wrote: > Hi Afzal > > On Thu, 10 May 2012, Mohammed, Afzal wrote: > > > On Tue, May 08, 2012 at 21:02:33, Paul Walmsley wrote: > > (attribution lost) Hmm, second time, normally I try to delete as much as possible contents from the origin

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-21 Thread Paul Walmsley
Hi Afzal On Thu, 10 May 2012, Mohammed, Afzal wrote: > On Tue, May 08, 2012 at 21:02:33, Paul Walmsley wrote: (attribution lost) > > > > Major reason was that there are some boards that rely on bootloader > > > settings, eg. kernel does not do any setting for smsc911x. I did not > > > want to

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-11 Thread Mohammed, Afzal
Hi Paul, On Thu, May 10, 2012 at 11:33:44, Mohammed, Afzal wrote: > Hi Paul, > > On Tue, May 08, 2012 at 21:02:33, Paul Walmsley wrote: > > > > Major reason was that there are some boards that rely on bootloader > > > settings, eg. kernel does not do any setting for smsc911x. I did not > > > wan

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-09 Thread Mohammed, Afzal
Hi Paul, On Tue, May 08, 2012 at 21:02:33, Paul Walmsley wrote: > > Major reason was that there are some boards that rely on bootloader > > settings, eg. kernel does not do any setting for smsc911x. I did not > > want to break those, at least it causes problem with omap3evm, see below > > But th

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-08 Thread Paul Walmsley
Hi On Tue, 8 May 2012, Mohammed, Afzal wrote: > If HWMOD_NO_INIT_RESET is not present, it would break GPMC on > many of the existing boards. IMHO, that should also be fixed as part of your changes, to remove what seems to be an unnecessary bootloader dependency. http://marc.info/?l=linux-omap&

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-08 Thread Paul Walmsley
On Mon, 7 May 2012, Mohammed, Afzal wrote: > On Sun, May 06, 2012 at 07:34:07, Paul Walmsley wrote: (attribution lost) > > > +static struct omap_hwmod omap3xxx_gpmc_hwmod = { > > > + .name = "gpmc", > > > + .class = &omap3xxx_gpmc_hwmod_class, > > > + .clkdm_name = "l3_ini

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-08 Thread Mohammed, Afzal
Hi Paul, On Mon, May 07, 2012 at 16:42:16, Mohammed, Afzal wrote: > > > +static struct omap_hwmod omap3xxx_gpmc_hwmod = { > > > + .name = "gpmc", > > > + .class = &omap3xxx_gpmc_hwmod_class, > > > + .clkdm_name = "l3_init_clkdm", > > > + .mpu_irqs = omap3xxx_gpmc_irqs

RE: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-07 Thread Mohammed, Afzal
Hi Paul, On Sun, May 06, 2012 at 07:34:07, Paul Walmsley wrote: > Did you notice the warning that this patch generates on boot? > > omap_hwmod: gpmc: cannot be enabled for reset (3) > > The HWMOD_NO_IDLEST hwmod flag is needed, since there is no GPMC IDLEST > bit. Yes, putting that flag makes

Re: [PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-05 Thread Paul Walmsley
Hello Afzal a few comments On Wed, 2 May 2012, Afzal Mohammed wrote: > Add gpmc hwmod and associated interconnect data > > Signed-off-by: Afzal Mohammed Did you notice the warning that this patch generates on boot? omap_hwmod: gpmc: cannot be enabled for reset (3) The HWMOD_NO_IDLEST hwmod

[PATCH v4-alt 3/6] ARM: OMAP3: hwmod data: add gpmc

2012-05-02 Thread Afzal Mohammed
Add gpmc hwmod and associated interconnect data Signed-off-by: Afzal Mohammed --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 52 1 file changed, 52 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.