RE: [PATCH v4 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread G, Manjunath Kondaiah
Santosh > Subject: Re: [PATCH v4 01/13] OMAP: DMA: Replace read/write > macros with functions > > Hi, > > * G, Manjunath Kondaiah [101108 05:58]: > > > +static u16 reg_map_omap1[] = { > > + [GCR1] = 0x400, > > + [GSCR] = 0x404, > > +

Re: [PATCH v4 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-08 Thread Tony Lindgren
Hi, * G, Manjunath Kondaiah [101108 05:58]: > +static u16 reg_map_omap1[] = { > + [GCR1] = 0x400, > + [GSCR] = 0x404, > + [GRST] = 0x408, ... > +}; The above you should move to mach-omap1/dma.c and pass it in the init function to plat-omap/dma.c. Let's try

[PATCH v4 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-08 Thread G, Manjunath Kondaiah
The low level read/write macros are replaced with static inline functions and register offsets are handled through static register offset tables mapped through enumeration constants. The objective of this patch is to prepare for omap dma driver cleanup and dma hwmod implementation. The code optimi