RE: [PATCH v4 REPOST 13/20] gpio/omap: cleanup omap_gpio_mod_init function

2011-07-20 Thread DebBarma, Tarun Kanti
[...] static int __init omap16xx_gpio_init(void) { int i; + void __iomem *base; + struct resource *res; + struct platform_device *pdev; + struct omap_gpio_platform_data *pdata; if (!cpu_is_omap16xx()) return -EINVAL; - for (i = 0; i

[PATCH v4 REPOST 13/20] gpio/omap: cleanup omap_gpio_mod_init function

2011-07-16 Thread Tarun Kanti DebBarma
With register offsets now defined for respective OMAP versions we can get rid of cpu_class_* checks. This function now has common initialization code for all OMAP versions. Initialization specific to OMAP16xx has been moved within omap16xx_gpio_init(). Signed-off-by: Tarun Kanti DebBarma

Re: [PATCH v4 REPOST 13/20] gpio/omap: cleanup omap_gpio_mod_init function

2011-07-16 Thread Todd Poynor
On Sat, Jul 16, 2011 at 01:45:45PM +0530, Tarun Kanti DebBarma wrote: With register offsets now defined for respective OMAP versions we can get rid of cpu_class_* checks. This function now has common initialization code for all OMAP versions. Initialization specific to OMAP16xx has been moved