Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2012-05-23 Thread David Brown
On Fri, Nov 18, 2011 at 04:47:17PM +0530, Rajendra Nayak wrote: + xyzreg: regulator@0 { + regulator-min-microvolt = 100; + regulator-max-microvolt = 250; + regulator-always-on; + vin-supply = vin; + }; Just noticed this, but

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Thomas Abraham
Hi Mark, On 4 December 2011 21:24, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sun, Dec 04, 2011 at 06:51:23PM +0530, Thomas Abraham wrote: For regulators that are not turned on by bootloader, and which require 'apply_uV' constraint, is there any alternative for turning on the

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 02:40:50PM +0530, Thomas Abraham wrote: On 4 December 2011 21:24, Mark Brown If the regulator isn't software managed then always_on covers this - the regulator core will enable any always_on regulators that haven't been enabled already. Thanks for the hint. I was

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Thomas Abraham
On 5 December 2011 16:04, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Dec 05, 2011 at 02:40:50PM +0530, Thomas Abraham wrote: On 4 December 2011 21:24, Mark Brown If the regulator isn't software managed then always_on covers this - the regulator core will enable any

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 04:14:40PM +0530, Thomas Abraham wrote: On 5 December 2011 16:04, Mark Brown With the regulator device tree bindings if the regulator is configured to run a single voltage the bindings will set apply_uV unconditionally so there's no need for a separate constraint.

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Thomas Abraham
On 5 December 2011 16:27, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Dec 05, 2011 at 04:14:40PM +0530, Thomas Abraham wrote: On 5 December 2011 16:04, Mark Brown With the regulator device tree bindings if the regulator is configured to run a single voltage the bindings

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-05 Thread Rajendra Nayak
On Monday 05 December 2011 04:27 PM, Mark Brown wrote: On Mon, Dec 05, 2011 at 04:14:40PM +0530, Thomas Abraham wrote: On 5 December 2011 16:04, Mark Brown With the regulator device tree bindings if the regulator is configured to run a single voltage the bindings will set apply_uV

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-04 Thread Thomas Abraham
On 18 November 2011 16:47, Rajendra Nayak rna...@ti.com wrote: The helper routine is meant to be used by the regulator drivers to extract the regulator_init_data structure from the data that is passed from device tree. 'consumer_supplies' which is part of regulator_init_data is not extracted

Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-12-04 Thread Mark Brown
On Sun, Dec 04, 2011 at 06:51:23PM +0530, Thomas Abraham wrote: For regulators that are not turned on by bootloader, and which require 'apply_uV' constraint, is there any alternative for turning on the regulator when using dt? If the regulator isn't software managed then always_on covers this

[PATCH v5 1/4] regulator: helper routine to extract regulator_init_data

2011-11-18 Thread Rajendra Nayak
The helper routine is meant to be used by the regulator drivers to extract the regulator_init_data structure from the data that is passed from device tree. 'consumer_supplies' which is part of regulator_init_data is not extracted as the regulator consumer mappings are passed through DT