Re: [PATCH v5 3/7] regulator: add pbias regulator support

2013-12-12 Thread Balaji T K
On Wednesday 11 December 2013 12:03 AM, Tony Lindgren wrote: * Balaji T K [131210 06:36]: pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. Good to se

Re: [PATCH v5 3/7] regulator: add pbias regulator support

2013-12-11 Thread Mark Brown
On Tue, Dec 10, 2013 at 08:04:58PM +0530, Balaji T K wrote: > pbias register controls internal power supply to sd card i/o pads > in most OMAPs (OMAP2-5, DRA7). > Control bits for selecting voltage level and > enabling/disabling are in the same PBIAS register. This looks OK from a regulator API po

Re: [PATCH v5 3/7] regulator: add pbias regulator support

2013-12-10 Thread Tony Lindgren
* Tony Lindgren [131210 10:34]: > * Balaji T K [131210 06:36]: > > pbias register controls internal power supply to sd card i/o pads > > in most OMAPs (OMAP2-5, DRA7). > > Control bits for selecting voltage level and > > enabling/disabling are in the same PBIAS register. > > Good to see this, fe

Re: [PATCH v5 3/7] regulator: add pbias regulator support

2013-12-10 Thread Tony Lindgren
* Balaji T K [131210 06:36]: > pbias register controls internal power supply to sd card i/o pads > in most OMAPs (OMAP2-5, DRA7). > Control bits for selecting voltage level and > enabling/disabling are in the same PBIAS register. Good to see this, few comments below. > +++ lo/Documentation/devic

[PATCH v5 3/7] regulator: add pbias regulator support

2013-12-10 Thread Balaji T K
pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. Signed-off-by: Balaji T K --- Documentation/devicetree/bindings/regulator/pbias-regulator.txt | 21