Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-28 Thread Kadiyala, Kishore
Hi Tony, On Sat, Feb 26, 2011 at 4:59 PM, Kadiyala, Kishore wrote: > Hi Tony, > > On Sat, Feb 26, 2011 at 2:27 AM, Tony Lindgren wrote: >> * Tony Lindgren [110225 12:42]: >>> * Kishore Kadiyala [110225 09:00]: >>> > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) >>> ... >>>

Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-26 Thread Kadiyala, Kishore
Hi Tony, On Sat, Feb 26, 2011 at 2:27 AM, Tony Lindgren wrote: > * Tony Lindgren [110225 12:42]: >> * Kishore Kadiyala [110225 09:00]: >> > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) >> ... >> >> > +   static int mmc_num; >> > + >> > +   c += mmc_num; >> >> This does not

Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Tony Lindgren
* Tony Lindgren [110225 12:42]: > * Kishore Kadiyala [110225 09:00]: > > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) > ... > > > + static int mmc_num; > > + > > + c += mmc_num; > > This does not look right.. So since mmc_num is static, it gets initialized to 0, then i

Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Tony Lindgren
* Kishore Kadiyala [110225 09:00]: > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) ... > + static int mmc_num; > + > + c += mmc_num; This does not look right.. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to m

[PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kishore Kadiyala
Changes involves: 1) Remove controller reset in devices.c which is taken care of by hwmod framework. 2) Omap2420 platform consists of mmc block as in omap1 and not the hsmmc block as present in omap2430, omap3, omap4 platforms. Removing all base address macro defines except keeping one for