Re: [PATCH v6 2/7] wl1271: propagate set_power's return value

2010-09-16 Thread Luciano Coelho
On Thu, 2010-09-16 at 21:53 +0200, ext Ohad Ben-Cohen wrote: > On Thu, Sep 16, 2010 at 9:40 PM, Luciano Coelho > wrote: > >> + int ret = wl->if_ops->power(wl, true); > > > > I think it look nicer if you keep the "int ret" in one line by itself > > and then do a ret = wl->if_ops... on another o

Re: [PATCH v6 2/7] wl1271: propagate set_power's return value

2010-09-16 Thread Ohad Ben-Cohen
On Thu, Sep 16, 2010 at 9:40 PM, Luciano Coelho wrote: >> +     int ret = wl->if_ops->power(wl, true); > > I think it look nicer if you keep the "int ret" in one line by itself > and then do a ret = wl->if_ops... on another one. Fixed. >> +static int wl1271_sdio_power_on(struct wl1271 *wl) >>  {

Re: [PATCH v6 2/7] wl1271: propagate set_power's return value

2010-09-16 Thread Luciano Coelho
On Thu, 2010-09-16 at 01:22 +0200, ext Ohad Ben-Cohen wrote: > Make it possible for the set power method to indicate a > success/failure return value. This is needed to support > more complex power on/off operations such as SDIO > power manipulations. > > Signed-off-by: Ohad Ben-Cohen > --- Some

[PATCH v6 2/7] wl1271: propagate set_power's return value

2010-09-15 Thread Ohad Ben-Cohen
Make it possible for the set power method to indicate a success/failure return value. This is needed to support more complex power on/off operations such as SDIO power manipulations. Signed-off-by: Ohad Ben-Cohen --- drivers/net/wireless/wl12xx/wl1271.h |2 +- drivers/net/wireless/wl12x