Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-27 Thread DebBarma, Tarun Kanti
On Tue, Sep 27, 2011 at 4:40 AM, Kevin Hilman khil...@ti.com wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: [...] As pointed out by Kevin, debounce clock was not getting disabled. In my testing I was somehow grepping CORE power domain instead of PER power domain and hence missed

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-27 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Tue, Sep 27, 2011 at 4:40 AM, Kevin Hilman khil...@ti.com wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: [...] As pointed out by Kevin, debounce clock was not getting disabled. In my testing I was somehow grepping CORE power

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-27 Thread DebBarma, Tarun Kanti
On Tue, Sep 27, 2011 at 9:52 PM, Kevin Hilman khil...@ti.com wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Tue, Sep 27, 2011 at 4:40 AM, Kevin Hilman khil...@ti.com wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: [...] As pointed out by Kevin, debounce clock was not

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-26 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: Santosh, Kevin, [...] After that, pm_runtime_put_sync() is called, which will trigger the driver's -runtime_suspend callback.  The -runtime_suspend() callback checks bank-mod_usage as well, and if zero, doesn't do anything (notably, it

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-26 Thread DebBarma, Tarun Kanti
[...] - Added the debounce clock fix in the end. Thanks.  Glad you found and fixed it. Rather than add this patch as a fix at the end, I prefer if the problem is fixed in the original patches that added/created the problem. Sure. I will put the changes in respective patches. -- Tarun [...]

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-26 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: [...] As pointed out by Kevin, debounce clock was not getting disabled. In my testing I was somehow grepping CORE power domain instead of PER power domain and hence missed it. The fix for the debounce clock issue is at the end of the email.

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-26 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: [...] - Added the debounce clock fix in the end. Thanks.  Glad you found and fixed it. Rather than add this patch as a fix at the end, I prefer if the problem is fixed in the original patches that added/created the problem. Sure. I will put

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-24 Thread Santosh Shilimkar
On Saturday 24 September 2011 09:26 AM, DebBarma, Tarun Kanti wrote: [...] After debugging this myself a bit, here's what I think may be going on. This may not be the only problem but here's at least one of them. First, debounce clocks are disabled in the runtime_suspend callback. When a

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-24 Thread DebBarma, Tarun Kanti
Santosh, Kevin, [...] After that, pm_runtime_put_sync() is called, which will trigger the driver's -runtime_suspend callback.  The -runtime_suspend() callback checks bank-mod_usage as well, and if zero, doesn't do anything (notably, it doesn't disable debounce clocks.) I need some

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-23 Thread DebBarma, Tarun Kanti
[...] After debugging this myself a bit, here's what I think may be going on. This may not be the only problem but here's at least one of them. First, debounce clocks are disabled in the runtime_suspend callback. When a GPIO is freed and it's the last one in the bank, bank-mod_usage goes to

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-22 Thread DebBarma, Tarun Kanti
On Tue, Sep 13, 2011 at 6:32 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of gpio_bank list instead of static array, use of unique platform

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-22 Thread Kevin Hilman
Hi Tarun, DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Tue, Sep 13, 2011 at 6:32 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-22 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of gpio_bank list instead of static array, use of unique platform specific value associated data

Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-22 Thread DebBarma, Tarun Kanti
[...] This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of gpio_bank list instead of static array, use of unique platform specific value associated data member to OMAP platforms to avoid cpu_is_*

[PATCH v7 00/26] gpio/omap: driver cleanup and fixes

2011-09-13 Thread Tarun Kanti DebBarma
This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of gpio_bank list instead of static array, use of unique platform specific value associated data member to OMAP platforms to avoid cpu_is_* checks. The