Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Govindraj
On Tue, Jan 3, 2012 at 5:22 PM, Bedia, Vaibhav wrote: > On Tue, Jan 03, 2012 at 16:01:52, Govindraj wrote: >> > >> > I have basic suspend-resume working on it. Strangely this works >> > irrespective >> > of the value of tty_dev wakeup entry. Do you know if this is expected on >> > OMAP? >> > >>

RE: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Bedia, Vaibhav
On Tue, Jan 03, 2012 at 16:01:52, Govindraj wrote: > > > > I have basic suspend-resume working on it. Strangely this works irrespective > > of the value of tty_dev wakeup entry. Do you know if this is expected on > > OMAP? > > > > AFAIK yes. Ok. > > > The other issue concerning runtime PM is t

Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Govindraj
On Tue, Jan 3, 2012 at 3:54 PM, Bedia, Vaibhav wrote: > Hi Govindraj, > > On Mon, Jan 02, 2012 at 16:00:37, Govindraj wrote: >> >> currently runtime pm is available from omap-serial device and not from >> tty_dev. >> Setting tty_dev wakeup is to use irq_wakeup from suspend available >> from serai

RE: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Bedia, Vaibhav
Hi Govindraj, On Mon, Jan 02, 2012 at 16:00:37, Govindraj wrote: > > currently runtime pm is available from omap-serial device and not from > tty_dev. > Setting tty_dev wakeup is to use irq_wakeup from suspend available > from serail_core layer which I think we are not using for omap-uart > and

Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-02 Thread Govindraj
Hi Vaibhav, On Mon, Jan 2, 2012 at 2:55 PM, Bedia, Vaibhav wrote: > Hello, > > On Fri, Nov 11, 2011 at 15:31:52, R, Govindraj wrote: > [...] >> >> -     if ((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) >> +     if (((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) >> +        

RE: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-02 Thread Bedia, Vaibhav
Hello, On Fri, Nov 11, 2011 at 15:31:52, R, Govindraj wrote: [...] > > - if ((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) > + if (((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads) > + && !uart_debug) > device_init_wakeup(&pdev->dev, t

[PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2011-11-11 Thread Govindraj.R
If OMAP UART is used as console uart and debug is enabled, avoid gating of uart clocks to print all debug prints. If uart clocks are gated then the debug prints from omap_device framework or hwmod framework can cause uart to enter recursive pm_runtime calls, which can cause a deadlock over power l