[PATCHV2 1/2] OMAP3630: Clock: add clksel_shift to struct clk

2010-01-18 Thread G.N, Vijayakumar
From f9a7f877368830fdf28f9892940d05517f07a582 Mon Sep 17 00:00:00 2001 From: Mike Turquette mturque...@ti.com Date: Tue, 12 Jan 2010 16:58:39 +0530 Subject: [PATCH 1/2] OMAP3630: Clock: add clksel_shift to struct clk Introduces clksel_shift to struct clk and populates the same for dpll4_m3_ck,

Re: [PATCHV2 1/2] OMAP3630: Clock: add clksel_shift to struct clk

2010-01-18 Thread Paul Walmsley
Mike, Vijayakumar, On Mon, 18 Jan 2010, G.N, Vijayakumar wrote: From f9a7f877368830fdf28f9892940d05517f07a582 Mon Sep 17 00:00:00 2001 From: Mike Turquette mturque...@ti.com Date: Tue, 12 Jan 2010 16:58:39 +0530 Subject: [PATCH 1/2] OMAP3630: Clock: add clksel_shift to struct clk Please

Re: [PATCHV2 1/2] OMAP3630: Clock: add clksel_shift to struct clk

2010-01-18 Thread Paul Walmsley
Another comment. On Mon, 18 Jan 2010, G.N, Vijayakumar wrote: diff --git a/arch/arm/mach-omap2/clock34xx_data.c b/arch/arm/mach-omap2/clock34xx_data.c index 6473247..ed17501 100755 --- a/arch/arm/mach-omap2/clock34xx_data.c +++ b/arch/arm/mach-omap2/clock34xx_data.c @@ -537,6 +537,7 @@

Re: [PATCHV2 1/2] OMAP3630: Clock: add clksel_shift to struct clk

2010-01-18 Thread Paul Walmsley
Correcting myself here: On Mon, 18 Jan 2010, Paul Walmsley wrote: This will chew up another (4 bytes * number of struct clks) Well, not really, since clksel_shift is a u8, and for the time being, it can nestle next to that other u8. But: and it doesn't seem necessary. It still doesn't