Re: [PATCHv3 03/20] ARM: OMAP4: PM: add support for device off

2012-06-14 Thread Tero Kristo
On Wed, 2012-06-13 at 17:21 +0200, Jean Pihet wrote: Hi Tero, I have a few remarks regarding the genericity of this code. I think it is better if the code in powerdomain.c stays generic and that the platform specific checks and operations be moved in the specific functions (via the

Re: [PATCHv3 03/20] ARM: OMAP4: PM: add support for device off

2012-06-14 Thread Tero Kristo
On Wed, 2012-06-13 at 17:21 +0200, Jean Pihet wrote: Hi Tero, I have a few remarks regarding the genericity of this code. I think it is better if the code in powerdomain.c stays generic and that the platform specific checks and operations be moved in the specific functions (via the

Re: [PATCHv3 03/20] ARM: OMAP4: PM: add support for device off

2012-06-13 Thread Jean Pihet
Hi Tero, I have a few remarks regarding the genericity of this code. I think it is better if the code in powerdomain.c stays generic and that the platform specific checks and operations be moved in the specific functions (via the pwrdm_ops struct). On Tue, Jun 12, 2012 at 5:31 PM, Tero Kristo

[PATCHv3 03/20] ARM: OMAP4: PM: add support for device off

2012-06-12 Thread Tero Kristo
On OMAP4+, device wide off-mode has its own enable mechanism in addition to powerdomain target states. This patch adds support for this on top of functional power states by overloading the OFF state for core pwrdm. On pwrdm level, the deepest power state supported by core pwrdm is OSWR. When user