Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-30 Thread Tero Kristo
Hi, Removed part of patch for easier readability of comments. On Tue, 2011-11-29 at 12:26 -0600, Menon, Nishanth wrote: On Fri, Nov 25, 2011 at 09:49, Tero Kristo t-kri...@ti.com wrote: clip @@ -227,11 +207,6 @@ static struct omap_voltdm_pmic omap4_iva_pmic = { static struct

Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-30 Thread Jean Pihet
Tero, On Fri, Nov 25, 2011 at 4:49 PM, Tero Kristo t-kri...@ti.com wrote: -static void __init omap3_vfsm_init(struct voltagedomain *voltdm) +static void omap3_set_i2c_timings(struct voltagedomain *voltdm, int off_mode)  { +       unsigned long voltsetup1; +       u32 tgt_volt; + +       if

Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-30 Thread Menon, Nishanth
On Wed, Nov 30, 2011 at 04:07, Tero Kristo t-kri...@ti.com wrote: On Tue, 2011-11-29 at 12:26 -0600, Menon, Nishanth wrote: On Fri, Nov 25, 2011 at 09:49, Tero Kristo t-kri...@ti.com wrote: more snip diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach-omap2/opp3xxx_data.c

Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-30 Thread Tero Kristo
On Wed, 2011-11-30 at 06:31 -0600, Menon, Nishanth wrote: On Wed, Nov 30, 2011 at 04:07, Tero Kristo t-kri...@ti.com wrote: On Tue, 2011-11-29 at 12:26 -0600, Menon, Nishanth wrote: On Fri, Nov 25, 2011 at 09:49, Tero Kristo t-kri...@ti.com wrote: more snip diff --git

Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-29 Thread Menon, Nishanth
On Fri, Nov 25, 2011 at 09:49, Tero Kristo t-kri...@ti.com wrote: Introduced two new voltage domain specific parameter structures, omap_vp_param and omap_vc_param. These are used to describe the minimum and maximum voltages for the voltagedomains, and also the sleep voltage levels. Existing

[PATCHv4 02/15] omap3+: voltage: parameter segregation

2011-11-25 Thread Tero Kristo
Introduced two new voltage domain specific parameter structures, omap_vp_param and omap_vc_param. These are used to describe the minimum and maximum voltages for the voltagedomains, and also the sleep voltage levels. Existing voltage levels are also moved into these new structures, and the voltage