Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-14 Thread Suman Anna
Hi Ohad, On 11/14/2014 01:11 AM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Nov 13, 2014 at 11:02 PM, Suman Anna s-a...@ti.com wrote: OK, lets take an example. I have say 2 device instances, say hwlock1: hwlock@0 { hwlock-num-locks = 32 hwlock-base-id

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-14 Thread Ohad Ben-Cohen
On Fri, Nov 14, 2014 at 7:09 PM, Suman Anna s-a...@ti.com wrote: It seems to me that hwspin_lock_request_specific failures should be used by clients to defer their probing. Why wouldn't such a simple solution work? Because the API always returns NULL on failures and there is no way for the

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Ohad Ben-Cohen
Hi Suman, On Wed, Nov 12, 2014 at 9:32 PM, Suman Anna s-a...@ti.com wrote: Is this the validation you mentioned which requires the existence of hwspinlock/core: maintain a list of registered hwspinlock banks ? Well, not exactly. The validation is on the following segment, + id =

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Suman Anna
Hi Ohad, On 11/13/2014 04:03 AM, Ohad Ben-Cohen wrote: Hi Suman, On Wed, Nov 12, 2014 at 9:32 PM, Suman Anna s-a...@ti.com wrote: Is this the validation you mentioned which requires the existence of hwspinlock/core: maintain a list of registered hwspinlock banks ? Well, not exactly. The

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Ohad Ben-Cohen
Hi Suman, On Thu, Nov 13, 2014 at 7:38 PM, Suman Anna s-a...@ti.com wrote: No, not always, because, either of them can be optional between different platform implementations. For example, on OMAP, the number of locks is read from an IP register, and not coded in DT. Similarly, base_id can be

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Suman Anna
Hi Ohad, On 11/13/2014 01:45 PM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Nov 13, 2014 at 7:38 PM, Suman Anna s-a...@ti.com wrote: No, not always, because, either of them can be optional between different platform implementations. For example, on OMAP, the number of locks is read from an IP

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-13 Thread Ohad Ben-Cohen
Hi Suman, On Thu, Nov 13, 2014 at 11:02 PM, Suman Anna s-a...@ti.com wrote: OK, lets take an example. I have say 2 device instances, say hwlock1: hwlock@0 { hwlock-num-locks = 32 hwlock-base-id = 0; #hwlock-cells = 1; };

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-12 Thread Ohad Ben-Cohen
Hi Suman, On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna s-a...@ti.com wrote: +int of_hwspin_lock_get_id(struct device_node *np, int index) +{ + struct hwspinlock_device *bank; + struct of_phandle_args args; + int id; + int ret; + + ret =

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-12 Thread Suman Anna
Hi Ohad, Thanks for the review. On 11/12/2014 01:08 PM, Ohad Ben-Cohen wrote: Hi Suman, On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna s-a...@ti.com wrote: +int of_hwspin_lock_get_id(struct device_node *np, int index) +{ + struct hwspinlock_device *bank; + struct

[PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-09-12 Thread Suman Anna
This patch adds three new OF helper functions to use/request locks from a hwspinlock device instantiated through a device-tree blob. 1. The of_hwspin_lock_get_num_locks() is a common OF helper function to read the 'hwlock-num-locks' property. 2. The of_hwspin_lock_get_base_id() is a common OF