Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Felipe Balbi
Hi, On Wed, Jul 31, 2013 at 11:17:52AM +0530, Sourav Poddar wrote: diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c new file mode 100644 index 000..3d10b69 --- /dev/null +++ b/drivers/spi/spi-ti-qspi.c @@ -0,0 +1,545 @@ snip +/* Device Control */ +#define

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Sourav Poddar
HI, On Wednesday 31 July 2013 01:19 PM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 11:17:52AM +0530, Sourav Poddar wrote: diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c new file mode 100644 index 000..3d10b69 --- /dev/null +++ b/drivers/spi/spi-ti-qspi.c @@ -0,0

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Felipe Balbi
Hi, On Wed, Jul 31, 2013 at 02:40:51PM +0530, Sourav Poddar wrote: +#defineQSPI_FRAME_MAX 0xfff Frame max is 4096, 0x1000, right ? Yes, this macro was used initially to fill the register bits, where 4095 = 4096 words. Will change it to now. you can make this something

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Sourav Poddar
On Wednesday 31 July 2013 02:50 PM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 02:40:51PM +0530, Sourav Poddar wrote: +#defineQSPI_FRAME_MAX 0xfff Frame max is 4096, 0x1000, right ? Yes, this macro was used initially to fill the register bits, where 4095 = 4096

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Felipe Balbi
Hi, On Wed, Jul 31, 2013 at 03:10:40PM +0530, Sourav Poddar wrote: words can be of any length (1, 2 or 4) bytes. So, I think it should be decremented by 1 only. this is wrong. hmm..got the point. I will pass the count address also to ti_qspi_read_data/write_data and make use of the switch

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Sourav Poddar
On Wednesday 31 July 2013 03:18 PM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 03:10:40PM +0530, Sourav Poddar wrote: words can be of any length (1, 2 or 4) bytes. So, I think it should be decremented by 1 only. this is wrong. hmm..got the point. I will pass the count address also to

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Trent Piepho
On Tue, Jul 30, 2013 at 10:47 PM, Sourav Poddar sourav.pod...@ti.com wrote: Test details: - Tested this on dra7 board. Test1: Ran mtd_stesstest for 4 iterations. - All iterations went through without failure. Test2: Use mtd utilities: - flash_erase to erase the flash

Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-31 Thread Sourav Poddar
On Thursday 01 August 2013 12:09 AM, Trent Piepho wrote: On Tue, Jul 30, 2013 at 10:47 PM, Sourav Poddarsourav.pod...@ti.com wrote: Test details: - Tested this on dra7 board. Test1: Ran mtd_stesstest for 4 iterations. - All iterations went through without failure. Test2:

[PATCHv7 1/2] drivers: spi: Add qspi flash controller

2013-07-30 Thread Sourav Poddar
The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface for accessing data form external spi devices. The patch will