Re: [PATCHv8 00/23]I2C big cleanup

2012-09-14 Thread Shubhrajyoti
On Friday 14 September 2012 02:58 AM, Kevin Hilman wrote: > Felipe Balbi writes: > >> Hi, >> >> On Thu, Sep 13, 2012 at 11:04:42AM -0700, Kevin Hilman wrote: >>> Kevin Hilman writes: >>> Kevin Hilman writes: >>> [...] >>> > Sorry to be late to the party (again), but still catching

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Felipe Balbi writes: > Hi, > > On Thu, Sep 13, 2012 at 11:04:42AM -0700, Kevin Hilman wrote: >> Kevin Hilman writes: >> >> > Kevin Hilman writes: >> > >> [...] >> >> >> Sorry to be late to the party (again), but still catching up after some >> >> time off. >> >> >> >> Unfortunately, this seri

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Felipe Balbi
Hi, On Thu, Sep 13, 2012 at 11:04:42AM -0700, Kevin Hilman wrote: > Kevin Hilman writes: > > > Kevin Hilman writes: > > > [...] > > >> Sorry to be late to the party (again), but still catching up after some > >> time off. > >> > >> Unfortunately, this series causes PM regressions on several OM

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Kevin Hilman writes: > Kevin Hilman writes: > [...] >> Sorry to be late to the party (again), but still catching up after some >> time off. >> >> Unfortunately, this series causes PM regressions on several OMAP >> platforms. I hope we can hold off on this until those issues are >> addressed. >

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Kevin Hilman
Felipe Balbi writes: [...] > I just ran same tests on pandaboard and i2c is suspended actually, > though no power domain transitions to RET. Do we not have retention > while idle on pandaboard ? Not for CORE. Only CPUx and MPU domains will be transitioning on OMAP4, and then, only with CPUidle

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Wolfram Sang
Hi Kevin, > Since this series is already merged, I suggest that the problem patch be > reverted, at least for v3.7 and until the problem is better understood > and tested. I thought I'll give you guys some more days to fix the problem before reverting. > > With that patch reverted, all my PM te

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti
On Thursday 13 September 2012 11:34 AM, Shubhrajyoti wrote: > > At least on 3530/Overo and 3730/Overo, CORE no longer hits retenion (or > > off) during idle. I dont have an Overo, anyways will see if I can get one However on beagleXm even off count increases / # grep "^core_pwrdm" /debug/pm_deb

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Felipe Balbi
Hi, On Thu, Sep 13, 2012 at 11:34:48AM +0530, Shubhrajyoti wrote: > On Thursday 13 September 2012 03:57 AM, Kevin Hilman wrote: > > Shubhrajyoti D writes: > > > > [...] > > > >> This is the cleanup only series. > >> > >> Tested on omap4sdp and 3430sdp. > > It would be extremely helpful if you

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti
On Thursday 13 September 2012 03:57 AM, Kevin Hilman wrote: > Shubhrajyoti D writes: > > [...] > >> This is the cleanup only series. >> >> Tested on omap4sdp and 3430sdp. > It would be extremely helpful if you would describe how this was tested. > And for me, it would be a source of extreme joy

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Felipe Balbi
On Wed, Sep 12, 2012 at 03:27:22PM -0700, Kevin Hilman wrote: > Shubhrajyoti D writes: > > [...] > > > > > This is the cleanup only series. > > > > Tested on omap4sdp and 3430sdp. > > It would be extremely helpful if you would describe how this was tested. > And for me, it would be a source

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Kevin Hilman writes: > Wolfram Sang writes: > >> On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: > > [...] > >>> This is the cleanup only series. >>> >>> Tested on omap4sdp and 3430sdp. >>> >>> The following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: >>>

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Wolfram Sang writes: > On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: [...] >> This is the cleanup only series. >> >> Tested on omap4sdp and 3430sdp. >> >> The following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: >> >> Linux 3.6-rc5 (2012-09-08 16:43:

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Kevin Hilman
Shubhrajyoti D writes: [...] > > This is the cleanup only series. > > Tested on omap4sdp and 3430sdp. It would be extremely helpful if you would describe how this was tested. And for me, it would be a source of extreme joy if you described any PM testing. I gave this some additional PM test

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 06:46 PM, Wolfram Sang wrote: >> Tested on omap4sdp and 3430sdp. >> > >> > The following changes since commit >> > 55d512e245bc7699a8800e23df1a24195dd08217: >> > >> > Linux 3.6-rc5 (2012-09-08 16:43:45 -0700) >> > >> > are available in the git repository at: >>

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 04:27:54PM +0530, Shubhrajyoti D wrote: > Changes since v1: >- removed tabification on patch 6/17 >- removed dev_err() which was introduced on patch 09/17 > Changes since v2: > - do not set full fifo depth in the RDR interrupt. > - some change

[PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Shubhrajyoti D
Changes since v1: - removed tabification on patch 6/17 - removed dev_err() which was introduced on patch 09/17 Changes since v2: - do not set full fifo depth in the RDR interrupt. - some changelog updates. - rebase to the Wolfram's tree. Changes since v3: