RE: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP user header and register defs

2009-01-14 Thread Aguirre Rodriguez, Sergio Alberto
ri Ailus; Tuukka.O Toivonen; Nagalla, Hari > Subject: Re: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP user header and > register defs > > On Mon, 12 Jan 2009 20:03:15 -0600 > "Aguirre Rodriguez, Sergio Alberto" wrote: > > > +/* ISP Private IOCTLs */ > > +#de

Re: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP user header and register defs

2009-01-13 Thread Mauro Carvalho Chehab
On Mon, 12 Jan 2009 20:03:15 -0600 "Aguirre Rodriguez, Sergio Alberto" wrote: > +/* ISP Private IOCTLs */ > +#define VIDIOC_PRIVATE_ISP_CCDC_CFG\ > + _IOWR('V', BASE_VIDIOC_PRIVATE + 1, struct ispccdc_update_config) > +#define VIDIOC_PRIVATE_ISP_PRV_CFG \ > + _IOWR('V', BASE_VIDIO

Re: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP user header and register defs

2009-01-13 Thread Trilok Soni
Hi Sergio, > +++ b/arch/arm/plat-omap/include/mach/isp_user.h > @@ -0,0 +1,668 @@ > +/* > + * include/asm-arm/arch-omap/isp_user.h > + * Path doesn't match. Better remove paths from all files, as they keep changing, and maintaining them is hard. -- ---Trilok Soni http://triloksoni.wordpress.co