Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-10 Thread Sakari Ailus
Hans Verkuil wrote: Sergio has posted earlier a patchset containing a driver for using the ISP to process images from memory to memory. The ISP driver is used roughly the same way as with the omap34xxcam and real sensors. The interface towards the userspace offered by the driver, however, is

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-10 Thread Hans Verkuil
Hans Verkuil wrote: Sergio has posted earlier a patchset containing a driver for using the ISP to process images from memory to memory. The ISP driver is used roughly the same way as with the omap34xxcam and real sensors. The interface towards the userspace offered by the driver, however, is

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Sakari Ailus
Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based IOCTLs) for performing user-side Auto-exposure, Auto White

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Hans Verkuil
On Thursday 05 March 2009 21:11:02 Sakari Ailus wrote: Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 09:39:48 ext Hans Verkuil wrote: BTW, do I understand correctly that e.g. lens drivers also get their own /dev/videoX node? Please tell me I'm mistaken! Since that would be so very wrong. You're mistaken :) With the v4l2-int-interface/omap34xxcam camera driver

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Sakari Ailus
Hans Verkuil wrote: On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: Thank you for your kind explanation Hans. Problem is omap3 camera subsystem is making device node for every int device attached to it. That's wrong. Multiple devices should only be created if they can all

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: Hans Verkuil wrote: On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: Thank you for your kind explanation Hans. Problem is omap3 camera subsystem is making device node for every int device attached to it. That's

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Aguirre Rodriguez, Sergio Alberto
@vger.kernel.org; Nagalla, Hari; linux-me...@vger.kernel.org Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: Hans Verkuil wrote: On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: Thank you for your kind

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
; Toivonen Tuukka.O (Nokia- D/Oulu); Aguirre Rodriguez, Sergio Alberto; linux-omap@vger.kernel.org; Nagalla, Hari; linux-me...@vger.kernel.org Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: Hans Verkuil wrote: On Wednesday

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Aguirre Rodriguez, Sergio Alberto
...@vger.kernel.org; Nagalla, Hari; linux-me...@vger.kernel.org Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver On Wednesday 04 March 2009 22:46:07 Aguirre Rodriguez, Sergio Alberto wrote: -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Trent Piepho
On Wed, 4 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: As what I understand, we have 2 possible situations for multiple opens here: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread hermann pitton
Am Mittwoch, den 04.03.2009, 15:42 -0800 schrieb Trent Piepho: On Wed, 4 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: As what I understand, we have 2 possible situations for multiple opens here: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. -

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
(Nathaniel) Kim; Hiremath, Vaibhav; Toivonen Tuukka.O (Nokia-D/Oulu); linux- o...@vger.kernel.org; Nagalla, Hari; linux-me...@vger.kernel.org Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver On Wednesday 04 March 2009 22:46:07 Aguirre Rodriguez, Sergio Alberto wrote: -Original

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread DongSoo(Nathaniel) Kim
11/14] OMAP34XXCAM: Add driver Hi Tuukka, I understand that it is a huge thing to support VIDIOC_S_INPUT. But without that, we don't have any proper V4L2 api to get information about how many devices are attached to camera interface, and names of input devices...and so on. Because

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread Hans Verkuil
] On Behalf Of DongSoo(Nathaniel) Kim Sent: Tuesday, March 03, 2009 8:18 AM To: Tuukka.O Toivonen Cc: Aguirre Rodriguez, Sergio Alberto; linux-omap@vger.kernel.org; Ailus Sakari (Nokia-D/Helsinki); Nagalla, Hari Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver Hi Tuukka

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread Tuukka.O Toivonen
On Wednesday 04 March 2009 09:39:48 ext Hans Verkuil wrote: BTW, do I understand correctly that e.g. lens drivers also get their own /dev/videoX node? Please tell me I'm mistaken! Since that would be so very wrong. You're mistaken :) With the v4l2-int-interface/omap34xxcam camera driver one

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread DongSoo(Nathaniel) Kim
Hi Tuukka, I understand that it is a huge thing to support VIDIOC_S_INPUT. But without that, we don't have any proper V4L2 api to get information about how many devices are attached to camera interface, and names of input devices...and so on. Because VIDIOC_ENUMINPUT and VIDIOC_G_INPUT needs

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread Hiremath, Vaibhav
@vger.kernel.org; Ailus Sakari (Nokia-D/Helsinki); Nagalla, Hari Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver Hi Tuukka, I understand that it is a huge thing to support VIDIOC_S_INPUT. But without that, we don't have any proper V4L2 api to get information about how many devices

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread DongSoo(Nathaniel) Kim
: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver Hi Tuukka, I understand that it is a huge thing to support VIDIOC_S_INPUT. But without that, we don't have any proper V4L2 api to get information about how many devices are attached to camera interface, and names of input devices...and so on. Because

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread Sakari Ailus
DongSoo(Nathaniel) Kim wrote: This is quite confusing because in case of mine, I wanna make switchable between different cameras attached to omap camera interface. Currently the ISP doesn't have a very neat way of controlling its use. In the recent patches, there's a change that allows just

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread DongSoo(Nathaniel) Kim
Hello Sakari, Let me explain what I want to do. First of all, I need to make it clear that I'm not using bare sensors with omap3, but I'm using ISP included camera modules. To be more clear I can take a 3G handset for instance, which has dual cameras on it. Each camera has their own ISP on them,

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-23 Thread Tuukka.O Toivonen
On Monday 23 February 2009 10:08:54 ext DongSoo(Nathaniel) Kim wrote: So, logically it does not make sense with making device nodes of every single slave attached with OMAP3camera interface. Because they can't be opened at the same time,even if it is possible it should not work properly.

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread Arun KS
On Thu, Feb 12, 2009 at 1:22 PM, DongSoo Kim dongsoo@gmail.com wrote: Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors by now, so you mean this patch is not verified

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread Sakari Ailus
DongSoo Kim wrote: Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors by now, so you mean this patch is not verified working with some ISP modules? I haven't verified it myself.

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread DongSoo(Nathaniel) Kim
Hi Arun. I appreciate your helpful words! For the meantime, I need a concrete driver for my camera module first and I'm still working on it. I wish I could post my work as a patch ASAP :) Wish me luck! Cheers, Nate On Fri, Feb 13, 2009 at 6:31 PM, Arun KS getaru...@gmail.com wrote: On Thu,

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread DongSoo(Nathaniel) Kim
Hi! Sakari. On Fri, Feb 13, 2009 at 7:02 PM, Sakari Ailus sakari.ai...@maxwell.research.nokia.com wrote: DongSoo Kim wrote: Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-11 Thread Sakari Ailus
DongSoo Kim wrote: Hello. Hi, and thanks for the comments! +static int omap34xxcam_open(struct inode *inode, struct file *file) +{ snip + if (atomic_inc_return(vdev-users) == 1) { + isp_get(); + if (omap34xxcam_slave_power_set(vdev, V4L2_POWER_ON, +

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-11 Thread DongSoo Kim
Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors by now, so you mean this patch is not verified working with some ISP modules? I'm testing your patch on my own omap3 target board

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-10 Thread DongSoo Kim
Hello. +static int omap34xxcam_open(struct inode *inode, struct file *file) +{ snip + if (atomic_inc_return(vdev-users) == 1) { + isp_get(); + if (omap34xxcam_slave_power_set(vdev, V4L2_POWER_ON, +

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-05 Thread DongSoo Kim
Hello. This could be something trivial. On Tue, Jan 13, 2009 at 11:03 AM, Aguirre Rodriguez, Sergio Alberto saagui...@ti.com wrote: +/** + * struct omap34xxcam_hw_config - struct for vidioc_int_g_priv ioctl + * @xclk: OMAP34XXCAM_XCLK_A or OMAP34XXCAM_XCLK_B + * @sensor_isp: Is sensor

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-01-12 Thread Hans Verkuil
On Tuesday 13 January 2009 03:03:34 Aguirre Rodriguez, Sergio Alberto wrote: Signed-off-by: Sakari Ailus sakari.ai...@nokia.com Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |2 +