Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-30 Thread Felipe Balbi
On Thu, Dec 30, 2010 at 12:18:04PM +, Mark Brown wrote: On Wed, Dec 29, 2010 at 02:28:08PM +0200, Felipe Balbi wrote: I believe you meant something like below, I'll get back to this in a little while. Have lots to test: Yes, that looks like what I'd expect. Good, I'll clean the patches

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-30 Thread Mark Brown
On Wed, Dec 29, 2010 at 02:28:08PM +0200, Felipe Balbi wrote: > I believe you meant something like below, I'll get back to this in a > little while. Have lots to test: Yes, that looks like what I'd expect. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a m

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-29 Thread Felipe Balbi
Hi, On Wed, Dec 29, 2010 at 02:38:28AM +0200, Felipe Balbi wrote: On Tue, 2010-12-28 at 23:58 +, Mark Brown wrote: On Tue, Dec 28, 2010 at 07:14:19PM +0200, Felipe Balbi wrote: > +static void twl4030_sih_bus_sync_unlock(unsigned int irq) > +{ > + struct sih_agent*agent = get_

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Felipe Balbi
Hi, On Tue, 2010-12-28 at 23:58 +, Mark Brown wrote: > On Tue, Dec 28, 2010 at 07:14:19PM +0200, Felipe Balbi wrote: > > > +static void twl4030_sih_bus_sync_unlock(unsigned int irq) > > +{ > > + struct sih_agent*agent = get_irq_chip_data(irq); > > + > > + mutex_unlock(&age

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Mark Brown
On Tue, Dec 28, 2010 at 07:14:19PM +0200, Felipe Balbi wrote: > +static void twl4030_sih_bus_sync_unlock(unsigned int irq) > +{ > + struct sih_agent*agent = get_irq_chip_data(irq); > + > + mutex_unlock(&agent->irq_lock); > +} I suspect you need to do some sort of sync with the

[RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Felipe Balbi
drop all the locking around mask/unmask and implement bus_lock and bus_sync_unlock methods. Signed-off-by: Felipe Balbi --- drivers/mfd/twl4030-irq.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/tw