[RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-03-30 Thread Christoph Fritz
This patch sets gpio #interrupt-cells from a falsely acquired '1' to '2' referring to Documentation/devicetree/bindings/gpio/gpio-omap.txt: The first cell is the GPIO number. The second cell is used to specify flags: bits[3:0] trigger type and level flags: 1 = low-to-

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-03-30 Thread Javier Martinez Canillas
On Sat, Mar 30, 2013 at 9:21 AM, Christoph Fritz wrote: > This patch sets gpio #interrupt-cells from a falsely acquired '1' to '2' > referring to Documentation/devicetree/bindings/gpio/gpio-omap.txt: > > The first cell is the GPIO number. > The second cell is used to specify flags: >

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-01 Thread Christoph Fritz
Hi Javier On Sat, 2013-03-30 at 14:18 +0100, Javier Martinez Canillas wrote: > A call to gpio_request() to enable the GPIO bank is needed before > using a GPIO as an IRQ source, otherwise accesses to the GPIO bank > registers fails making the kernel to hang. Yes, that is exactly my problem here.

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-01 Thread Javier Martinez Canillas
On Mon, Apr 1, 2013 at 6:41 PM, Christoph Fritz wrote: > Hi Javier > > On Sat, 2013-03-30 at 14:18 +0100, Javier Martinez Canillas wrote: >> A call to gpio_request() to enable the GPIO bank is needed before >> using a GPIO as an IRQ source, otherwise accesses to the GPIO bank >> registers fails ma

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-02 Thread Christoph Fritz
On Mon, 2013-04-01 at 22:05 +0200, Javier Martinez Canillas wrote: > > As a quick-fix (hack) I wrote directly to the registers in gpio_probe() > > to enable GPIO banks. I now geht this: > > > >> > [0.214630] omap_gpio_probe, 1133, CM_CLKSEL_PER 0x48005040: > >> > 0x00ff > >> > [0.2146

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-02 Thread Jon Hunter
On 04/02/2013 10:55 AM, Christoph Fritz wrote: > On Mon, 2013-04-01 at 22:05 +0200, Javier Martinez Canillas wrote: > >>> As a quick-fix (hack) I wrote directly to the registers in gpio_probe() >>> to enable GPIO banks. I now geht this: >>> > [0.214630] omap_gpio_probe, 1133, CM_CLKSEL_PE

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-13 Thread Christoph Fritz
On Mon, 2013-04-01 at 22:05 +0200, Javier Martinez Canillas wrote: > On Mon, Apr 1, 2013 at 6:41 PM, Christoph Fritz > > As a quick-fix (hack) I wrote directly to the registers in gpio_probe() > > to enable GPIO banks. I now geht this: > > > >> > [0.214630] omap_gpio_probe, 1133, CM_CLKSEL_PER

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-13 Thread Javier Martinez Canillas
On Sat, Apr 13, 2013 at 7:42 PM, Christoph Fritz wrote: > On Mon, 2013-04-01 at 22:05 +0200, Javier Martinez Canillas wrote: >> On Mon, Apr 1, 2013 at 6:41 PM, Christoph Fritz >> > As a quick-fix (hack) I wrote directly to the registers in gpio_probe() >> > to enable GPIO banks. I now geht this: >

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-13 Thread Christoph Fritz
On Sat, 2013-04-13 at 20:30 +0200, Javier Martinez Canillas wrote: > On Sat, Apr 13, 2013 at 7:42 PM, Christoph Fritz > wrote: > Yes, my last approach to solve the IRQ flags not saved on the > IORESOURCE_IRQ struct resource issue is to add a new > irq_get_trigger_type() function to get the edge/l

Re: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two

2013-04-13 Thread Javier Martinez Canillas
On Sat, Apr 13, 2013 at 8:59 PM, Christoph Fritz wrote: > On Sat, 2013-04-13 at 20:30 +0200, Javier Martinez Canillas wrote: >> On Sat, Apr 13, 2013 at 7:42 PM, Christoph Fritz >> wrote: > >> Yes, my last approach to solve the IRQ flags not saved on the >> IORESOURCE_IRQ struct resource issue is