Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread andrzej zaborowski
2008/6/30 David Brownell <[EMAIL PROTECTED]>: > On Monday 30 June 2008, Felipe Balbi wrote: >> The patch won't probe. But if you just copy what's added in >> board-omap3430sdp.c >> should work. > > Better: that controller data should be provided by SOC glue > in those cases (omap2430, omap 3*, Da

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2008 at 11:33:15AM -0700, David Brownell wrote: > On Monday 30 June 2008, Felipe Balbi wrote: > > The patch won't probe. But if you just copy what's added in > > board-omap3430sdp.c > > should work. > > Better: that controller data should be provided by SOC glue > in those cases

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread David Brownell
On Monday 30 June 2008, Felipe Balbi wrote: > The patch won't probe. But if you just copy what's added in > board-omap3430sdp.c > should work. Better: that controller data should be provided by SOC glue in those cases (omap2430, omap 3*, DaVinci, etc). If it's not board-specific, it doesn't bel

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2008 at 07:56:36PM +0200, Koen Kooi wrote: > I was wondering what would happen if I would test the patch on > beagleboard, now I know :) The patch won't probe. But if you just copy what's added in board-omap3430sdp.c should work. afaict, they have the same configuration for mus

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Koen Kooi
Op 30 jun 2008, om 19:49 heeft Felipe Balbi het volgende geschreven: On Mon, Jun 30, 2008 at 07:29:28PM +0200, Koen Kooi wrote: Op 30 jun 2008, om 13:50 heeft Felipe Balbi het volgende geschreven: Use platform_data to pass musb configuration-specific details to musb driver. It's easier to

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2008 at 07:29:28PM +0200, Koen Kooi wrote: > > Op 30 jun 2008, om 13:50 heeft Felipe Balbi het volgende geschreven: > >> Use platform_data to pass musb configuration-specific >> details to musb driver. >> >> It's easier to maintain in the sense that neither board >> will affect the

Re: [RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Koen Kooi
Op 30 jun 2008, om 13:50 heeft Felipe Balbi het volgende geschreven: Use platform_data to pass musb configuration-specific details to musb driver. It's easier to maintain in the sense that neither board will affect the other. For now tested on n800 only, wanna hear from everybody what guys th

[RFC][PATCH] usb: musb: pass configuration specifics via pdata

2008-06-30 Thread Felipe Balbi
Use platform_data to pass musb configuration-specific details to musb driver. It's easier to maintain in the sense that neither board will affect the other. For now tested on n800 only, wanna hear from everybody what guys think before test on omap3430sdp Signed-off-by: Felipe Balbi <[EMAIL PROTE