Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-19 Thread Mark A. Greer
On Mon, Nov 19, 2012 at 09:19:15AM -0700, Mark A. Greer wrote: > On Mon, Nov 19, 2012 at 11:01:44AM +0100, Peter Ujfalusi wrote: > > Hi, > > > > On 10/19/2012 12:20 AM, Mark A. Greer wrote: > > > Enable DMA prefetching by setting the 'OMAP_DMA_DST_SYNC_PREFETCH' > > > flag whenever there is a dest

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-19 Thread Mark A. Greer
On Mon, Nov 19, 2012 at 11:01:44AM +0100, Peter Ujfalusi wrote: > Hi, > > On 10/19/2012 12:20 AM, Mark A. Greer wrote: > > Enable DMA prefetching by setting the 'OMAP_DMA_DST_SYNC_PREFETCH' > > flag whenever there is a destination synchronized DMA transfer. > > Prefetching is not allowed on source

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-19 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 11:00:15AM +0100, Peter Ujfalusi wrote: > When we have prefetch enabled we tend to resume after pause from a slightly > off place than when the prefetch is disabled. That is exactly what I was expecting would happen having read how the DMA works. With memory->device transf

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-19 Thread Peter Ujfalusi
Hi, On 10/19/2012 12:20 AM, Mark A. Greer wrote: > Enable DMA prefetching by setting the 'OMAP_DMA_DST_SYNC_PREFETCH' > flag whenever there is a destination synchronized DMA transfer. > Prefetching is not allowed on source synchronized DMA transfers. > > Enabling prefetch significantly improves D

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-19 Thread Peter Ujfalusi
On 11/17/2012 12:31 PM, Russell King - ARM Linux wrote: > On Fri, Oct 19, 2012 at 02:45:55PM +0200, Péter Ujfalusi wrote: >> Hi, >> >> On 10/19/2012 01:33 AM, Russell King - ARM Linux wrote: >>> I'm merely pointing out here that we need their feedback here before >>> deciding if there's anything fu

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-17 Thread Russell King - ARM Linux
On Fri, Oct 19, 2012 at 02:45:55PM +0200, Péter Ujfalusi wrote: > Hi, > > On 10/19/2012 01:33 AM, Russell King - ARM Linux wrote: > > I'm merely pointing out here that we need their feedback here before > > deciding if there's anything further that needs to happen. > > Thanks Russell, I'll take a

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-16 Thread Mark A. Greer
On Fri, Oct 19, 2012 at 02:45:55PM +0200, Péter Ujfalusi wrote: > Hi, > > On 10/19/2012 01:33 AM, Russell King - ARM Linux wrote: > > I would suggest getting some feedback from the ASoC people first, before > > trying to invent new APIs to work around this stuff. If they can live > > with having

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-11-05 Thread Mark A. Greer
On Fri, Oct 19, 2012 at 02:45:55PM +0200, Péter Ujfalusi wrote: > Hi, > > On 10/19/2012 01:33 AM, Russell King - ARM Linux wrote: > > I would suggest getting some feedback from the ASoC people first, before > > trying to invent new APIs to work around this stuff. If they can live > > with having

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-19 Thread Péter Ujfalusi
Hi, On 10/19/2012 01:33 AM, Russell King - ARM Linux wrote: > I would suggest getting some feedback from the ASoC people first, before > trying to invent new APIs to work around this stuff. If they can live > with having prefetch enabled on OMAP then there isn't an issue here. If > not, we need

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Mark A. Greer
On Fri, Oct 19, 2012 at 12:33:35AM +0100, Russell King - ARM Linux wrote: > On Thu, Oct 18, 2012 at 04:24:05PM -0700, Mark A. Greer wrote: > > On Thu, Oct 18, 2012 at 11:55:40PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Oct 18, 2012 at 03:20:46PM -0700, Mark A. Greer wrote: > > > > This

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Russell King - ARM Linux
On Thu, Oct 18, 2012 at 04:24:05PM -0700, Mark A. Greer wrote: > On Thu, Oct 18, 2012 at 11:55:40PM +0100, Russell King - ARM Linux wrote: > > On Thu, Oct 18, 2012 at 03:20:46PM -0700, Mark A. Greer wrote: > > > This patch seems fairly stable but I've only tested omap-sham (crypto) > > > and omap_h

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Mark A. Greer
On Thu, Oct 18, 2012 at 11:55:40PM +0100, Russell King - ARM Linux wrote: > On Thu, Oct 18, 2012 at 03:20:46PM -0700, Mark A. Greer wrote: > > This patch seems fairly stable but I've only tested omap-sham (crypto) > > and omap_hsmmc (mmc) on an am37x EVM. I also enabled burst mode but > > that mad

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Russell King - ARM Linux
On Thu, Oct 18, 2012 at 03:20:46PM -0700, Mark A. Greer wrote: > This patch seems fairly stable but I've only tested omap-sham (crypto) > and omap_hsmmc (mmc) on an am37x EVM. I also enabled burst mode but > that made the system unstable when exercising either omap-sham or > omap_hsmmc. I'm unawa

Re: [RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Mark A. Greer
On Thu, Oct 18, 2012 at 03:20:46PM -0700, Mark A. Greer wrote: > This patch seems fairly stable but I've only tested omap-sham (crypto) > and omap_hsmmc (mmc) on an am37x EVM. I also enabled burst mode but > that made the system unstable when exercising either omap-sham or > omap_hsmmc. I'm unaw

[RFC] dmaengine: omap-dma: Allow DMA controller to prefetch data

2012-10-18 Thread Mark A. Greer
Enable DMA prefetching by setting the 'OMAP_DMA_DST_SYNC_PREFETCH' flag whenever there is a destination synchronized DMA transfer. Prefetching is not allowed on source synchronized DMA transfers. Enabling prefetch significantly improves DMA performance. For example, running 'modprobe tcrypt sec=2