Charulatha V <ch...@ti.com> writes: > * Define gpio register offsets in SoC specific GPIO files and use > these register offsets while doing register read/write > * Remove the usage of CONFIG_ARCH_* checks and cpu_is* checks from > the below functions > _set_gpio_direction > _set_gpio_dataout > _get_gpio_dataout > _get_gpio_datain > * MPUIO is a common gpio bank->method for OMAP15xx, OMAP16xx and > OMAP7xx SoCs. Each of these SoCs has one bank with MPUIO type. > Hence handle MPUIO type GPIO banks in GPIO driver. > > Note: After the complete driver is cleaned up, the register offset > macros defined in OMAP GPIO driver would be removed > > Signed-off-by: Charulatha V <ch...@ti.com>
IMO, this isn't quite the direction we want to go for this cleanup. Register offsets should indeed be in SoC specific files, but rather than the driver calling pdata function pointers for the functions, the register offsets should instead be passed into the driver so the driver can have common functions. Also, MPUIO doesn't need to be treated as a special case. From the GPIO driver perspective, it's just another GPIO bank. On some SoCs, it happens to have a different width and stride, but the drive should handle that. I've also started on a GPIO cleanup (currently posted to linux-omap only) and I've taken a different approach. After I finish reviewing your series, I'll have some more ideas on how we might combine our efforts here. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
