Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-24 Thread Aneesh V
On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: Hi Aneesh, [...] +struct emif_data { + u8 duplicate; + u8 temperature_level; + u32 irq; + spinlock_t

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 12:10 PM, Aneesh V wrote: On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: Hi Aneesh, [...] +struct emif_data { + u8 duplicate; + u8 temperature_level; + u32 irq; + spinlock_t lock; /* lock to prevent races */ Nit: That comment is useless, since you already have

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-17 Thread Aneesh V
Hi Benoit, On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: Hi Aneesh, On 2/4/2012 1:16 PM, Aneesh V wrote: EMIF is an SDRAM controller used in various Texas Instruments SoCs. EMIF supports, based on its revision, one or more of LPDDR2/DDR2/DDR3 protocols. Add the basic

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-17 Thread Cousson, Benoit
Hi Aneesh, On 2/17/2012 2:26 PM, Aneesh V wrote: On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: On 2/4/2012 1:16 PM, Aneesh V wrote: [...] +/** + * struct emif_data - Per device static data for driver's use + * @duplicate: Whether the DDR devices attached to this EMIF + *

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-17 Thread Aneesh V
On Friday 17 February 2012 07:14 PM, Cousson, Benoit wrote: Hi Aneesh, [...] + emif = kzalloc(sizeof(struct emif_data), GFP_KERNEL); You should use the devm_* version of this API to get the simplify the error handling / removal. Please note that most of my allocations are happening

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-16 Thread Santosh Shilimkar
On Saturday 04 February 2012 05:46 PM, Aneesh V wrote: EMIF is an SDRAM controller used in various Texas Instruments SoCs. EMIF supports, based on its revision, one or more of LPDDR2/DDR2/DDR3 protocols. Add the basic infrastructure for EMIF driver that includes driver registration, probe,

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-16 Thread Aneesh V
On Thursday 16 February 2012 04:03 PM, Santosh Shilimkar wrote: On Saturday 04 February 2012 05:46 PM, Aneesh V wrote: EMIF is an SDRAM controller used in various Texas Instruments SoCs. EMIF supports, based on its revision, one or more of LPDDR2/DDR2/DDR3 protocols. Add the basic

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-16 Thread Cousson, Benoit
Hi Aneesh, On 2/4/2012 1:16 PM, Aneesh V wrote: EMIF is an SDRAM controller used in various Texas Instruments SoCs. EMIF supports, based on its revision, one or more of LPDDR2/DDR2/DDR3 protocols. Add the basic infrastructure for EMIF driver that includes driver registration, probe,

[RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-04 Thread Aneesh V
EMIF is an SDRAM controller used in various Texas Instruments SoCs. EMIF supports, based on its revision, one or more of LPDDR2/DDR2/DDR3 protocols. Add the basic infrastructure for EMIF driver that includes driver registration, probe, parsing of platform data etc. Signed-off-by: Aneesh V