[RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-02 Thread Ming Lei
This patch introduces one driver for face detection purpose. The driver is responsible for all v4l2 stuff, buffer management and other general things, and doesn't touch face detection hardware directly. Several interfaces are exported to low level drivers (such as the coming omap4 FD driver)which

[RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-02 Thread Ming Lei
This patch introduces one driver for face detection purpose. The driver is responsible for all v4l2 stuff, buffer management and other general things, and doesn't touch face detection hardware directly. Several interfaces are exported to low level drivers (such as the coming omap4 FD driver)which

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-05 Thread Sylwester Nawrocki
Hi Ming, (I've pruned the Cc list, leaving just the mailing lists) On 12/02/2011 04:02 PM, Ming Lei wrote: > This patch introduces one driver for face detection purpose. > > The driver is responsible for all v4l2 stuff, buffer management > and other general things, and doesn't touch face detecti

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-06 Thread Ming Lei
Hi, Thanks for your review. On Tue, Dec 6, 2011 at 5:55 AM, Sylwester Nawrocki wrote: > Hi Ming, > > (I've pruned the Cc list, leaving just the mailing lists) > > On 12/02/2011 04:02 PM, Ming Lei wrote: >> This patch introduces one driver for face detection purpose. >> >> The driver is responsib

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-06 Thread Sylwester Nawrocki
On 12/06/2011 03:07 PM, Ming Lei wrote: > Hi, > > Thanks for your review. > > On Tue, Dec 6, 2011 at 5:55 AM, Sylwester Nawrocki wrote: >> Hi Ming, >> >> (I've pruned the Cc list, leaving just the mailing lists) >> >> On 12/02/2011 04:02 PM, Ming Lei wrote: >>> This patch introduces one driver f

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-06 Thread Sylwester Nawrocki
On 12/06/2011 11:01 PM, Sylwester Nawrocki wrote: [...] > > It might be much better as the v4l2 events are associated with the frame > sequence. And if we use controls then you get control events for free, > and each event carries a frame sequence number int it > (http://linuxtv.org/downloads/v4l-d

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-07 Thread Ming Lei
Hi, On Wed, Dec 7, 2011 at 6:01 AM, Sylwester Nawrocki wrote: > On 12/06/2011 03:07 PM, Ming Lei wrote: >> Hi, >> >> Thanks for your review. >> >> On Tue, Dec 6, 2011 at 5:55 AM, Sylwester Nawrocki wrote: >>> Hi Ming, >>> >>> (I've pruned the Cc list, leaving just the mailing lists) >>> >>> On 1

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-08 Thread Sylwester Nawrocki
On 12/07/2011 02:40 PM, Ming Lei wrote: >>> I understand the API you mentioned here should belong to kernel internal >>> API, correct me if it is wrong. >> >> Yes, I meant the in kernel design, i.e. generic face detection kernel module >> and an OMAP4 FDIF driver. It makes lots of sense to separate

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-09 Thread Ming Lei
On Fri, Dec 9, 2011 at 7:25 AM, Sylwester Nawrocki wrote: > On 12/07/2011 02:40 PM, Ming Lei wrote: I understand the API you mentioned here should belong to kernel internal API, correct me if it is wrong. >>> >>> Yes, I meant the in kernel design, i.e. generic face detection kernel modul

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-11 Thread Sylwester Nawrocki
On 12/09/2011 04:10 PM, Ming Lei wrote: > On Fri, Dec 9, 2011 at 7:25 AM, Sylwester Nawrocki wrote: >> On 12/07/2011 02:40 PM, Ming Lei wrote: >>> Yes, that is the motivation of the generic FD module. I think we can focus >>> on >>> two use cases for the generic FD now: >>> >>> - one is to detect

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-11 Thread Sylwester Nawrocki
Hi Ming, On 12/02/2011 04:02 PM, Ming Lei wrote: > This patch introduces one driver for face detection purpose. > > The driver is responsible for all v4l2 stuff, buffer management > and other general things, and doesn't touch face detection hardware > directly. Several interfaces are exported to

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread Ming Lei
Hi, On Mon, Dec 12, 2011 at 1:43 AM, Sylwester Nawrocki >> For OMAP4 FD, it is not needed to include FD into MC framework since a >> intermediate buffer is always required. If your HW doesn't belong to this >> case, what is the output of your HW FD in the link? Also sounds FD results >> may not

RE: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread HeungJun, Kim
- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Ming Lei > Sent: Monday, December 12, 2011 6:50 PM > To: Sylwester Nawrocki > Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; lin

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread Sylwester Nawrocki
Hi, On 12/12/2011 10:49 AM, Ming Lei wrote: >>> If FD result is associated with a frame, how can user space get the frame >>> seq if no v4l2 buffer is involved? Without a frame sequence, it is a bit >>> difficult to retrieve FD results from user space. >> >> If you pass image data in memory buffer

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread Ming Lei
th OMAP FDIF. You have been doing it already, :-) thanks, -- Ming Lei > > Thank you. > > Regards, > Heungjun Kim > > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Min

RE: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread HeungJun, Kim
ead.org; linux-ker...@vger.kernel.org; linux- > me...@vger.kernel.org > Subject: Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver > module > > Hi, > > On Mon, Dec 12, 2011 at 8:08 PM, HeungJun, Kim wrote: > > Hi Ming, > > > > It's maybe la

Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver module

2011-12-12 Thread Ming Lei
gt;> Cc: Sylwester Nawrocki; linux-omap@vger.kernel.org; linux-arm- >> ker...@lists.infradead.org; linux-ker...@vger.kernel.org; linux- >> me...@vger.kernel.org >> Subject: Re: [RFC PATCH v1 6/7] media: video: introduce face detection driver >> module >> >> H