Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-02 Thread Varadarajan, Charulatha
On Thu, Dec 2, 2010 at 15:53, Hari Kanigeri wrote: > On Wed, Dec 1, 2010 at 11:16 PM, Varadarajan, Charulatha wrote: >> On Thu, Dec 2, 2010 at 07:57, Kanigeri, Hari wrote: >>> On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari wrote: On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha >

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-02 Thread Hari Kanigeri
On Wed, Dec 1, 2010 at 11:16 PM, Varadarajan, Charulatha wrote: > On Thu, Dec 2, 2010 at 07:57, Kanigeri, Hari wrote: >> On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari wrote: >>> On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha >>> wrote: David, >>> > +               if (

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-01 Thread Varadarajan, Charulatha
On Thu, Dec 2, 2010 at 07:57, Kanigeri, Hari wrote: > On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari wrote: >> On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha >> wrote: >>> David, >> >>> +               if (!oh) +                       goto error; + +              

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-01 Thread Kanigeri, Hari
On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari wrote: > On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha wrote: >> David, > >> >>> +               if (!oh) >>> +                       goto error; >>> + >>> +               data->base = oh->_mpu_rt_va; >> >> not required. Make use of platfo

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-01 Thread Kanigeri, Hari
On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha wrote: > David, > >> +               if (!oh) >> +                       goto error; >> + >> +               data->base = oh->_mpu_rt_va; > > not required. Make use of platform_get APIs in probe to extract the > base, dma and irq info using

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-11-30 Thread Varadarajan, Charulatha
David, On Wed, Dec 1, 2010 at 01:28, David Sin wrote: > This patch adds support for DMM-PAT initialization and programming. > > Signed-off-by: David Sin > Signed-off-by: Lajos Molnar > --- >  arch/arm/mach-omap2/dmm-omap44xx.c     |   81 ++ >  arch/arm/mach-omap2/include/mach/dmm.h

[RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-11-30 Thread David Sin
This patch adds support for DMM-PAT initialization and programming. Signed-off-by: David Sin Signed-off-by: Lajos Molnar --- arch/arm/mach-omap2/dmm-omap44xx.c | 81 ++ arch/arm/mach-omap2/include/mach/dmm.h | 92 drivers/misc/tiler/dmm-main.c | 18