Re: [alsa-devel] [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver

2008-10-03 Thread Liam Girdwood
On Fri, 2008-10-03 at 11:18 +0300, Tony Lindgren wrote: > Hi, > > * Arun KS <[EMAIL PROTECTED]> [081002 12:18]: > > ASoC codec driver for TLV320AIC23 device > > One comment below based on a quick browse. > > > > > +static void tlv320aic23_shutdown(struct snd_pcm_substream *substream) > > +{ >

Re: [alsa-devel] [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver

2008-10-02 Thread Mark Brown
On Thu, Oct 02, 2008 at 02:55:27PM +0530, Arun KS wrote: > ASoC codec driver for TLV320AIC23 device > Signed-off-by: Arun KS <[EMAIL PROTECTED]> This looks good and it's probably as well to merge it now since the one issue below is mostly cosmetic so if nothing else it'll be easier to review incr