Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-23 Thread David Miller
From: "Hebbar, Gururaja" Date: Thu, 23 May 2013 11:28:38 + > On Thu, May 23, 2013 at 12:27:41, David Miller wrote: >> From: Mugunthan V N >> Date: Tue, 21 May 2013 15:24:58 +0530 >> >> > + priv->pins_default = pinctrl_lookup_state(priv->pinctrl, >> > +

RE: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-23 Thread Hebbar, Gururaja
On Thu, May 23, 2013 at 12:27:41, David Miller wrote: > From: Mugunthan V N > Date: Tue, 21 May 2013 15:24:58 +0530 > > > + priv->pins_default = pinctrl_lookup_state(priv->pinctrl, > > + PINCTRL_STATE_DEFAULT); > > This is not indented correctl

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-23 Thread Mugunthan V N
On 5/23/2013 12:27 PM, David Miller wrote: From: Mugunthan V N Date: Tue, 21 May 2013 15:24:58 +0530 + priv->pins_default = pinctrl_lookup_state(priv->pinctrl, + PINCTRL_STATE_DEFAULT); This is not indented correctly. Argument on th

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-22 Thread David Miller
From: Mugunthan V N Date: Tue, 21 May 2013 15:24:58 +0530 > + priv->pins_default = pinctrl_lookup_state(priv->pinctrl, > + PINCTRL_STATE_DEFAULT); This is not indented correctly. Argument on the second, and subsequent, lines of a function

[net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-21 Thread Mugunthan V N
From: Hebbar Gururaja Amend cpsw controller to optionally take a pin control handle and set the state of the pins to: - "default" on boot, resume - "sleep" on suspend() This should make it possible to optimize energy usage for the pins for the suspend/resume cycle. If any of the above pin stat