Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-03-01 Thread Pavol Kurina
Am 28.02.2011 09:43, schrieb Felipe Balbi: On Fri, Feb 25, 2011 at 07:41:47PM +, Pavol Kurina wrote: Felipe Balbi ti.com> writes: struct usb_request's list_head is supposed to be used only by gadget drivers, but musb is abusing that. Give struct musb_request its own list_head and prevent

Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-03-01 Thread Felipe Balbi
On Tue, Mar 01, 2011 at 05:40:59PM +0200, Felipe Balbi wrote: > Hi, > > On Tue, Mar 01, 2011 at 05:39:18PM +0200, Felipe Balbi wrote: > > > /* if the hardware doesn't have the request, easy ... */ > > > - if (musb_ep->req_list.next != &request->list || musb_ep->busy) > > > + if

Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-03-01 Thread Felipe Balbi
Hi, On Tue, Mar 01, 2011 at 05:39:18PM +0200, Felipe Balbi wrote: > > /* if the hardware doesn't have the request, easy ... */ > > - if (musb_ep->req_list.next != &request->list || musb_ep->busy) > > + if (musb_ep->req_list.next != &req->list || musb_ep->busy) > >

Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-03-01 Thread Felipe Balbi
On Tue, Mar 01, 2011 at 04:36:53PM +0100, Pavol Kurina wrote: > Am 28.02.2011 09:43, schrieb Felipe Balbi: > >On Fri, Feb 25, 2011 at 07:41:47PM +, Pavol Kurina wrote: > >>Felipe Balbi ti.com> writes: > >>>struct usb_request's list_head is supposed to be > >>>used only by gadget drivers, but

Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-02-28 Thread Felipe Balbi
On Fri, Feb 25, 2011 at 07:41:47PM +, Pavol Kurina wrote: > Felipe Balbi ti.com> writes: > > > > struct usb_request's list_head is supposed to be > > used only by gadget drivers, but musb is abusing > > that. Give struct musb_request its own list_head > > and prevent musb from poking into oth

Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-02-25 Thread Pavol Kurina
Felipe Balbi ti.com> writes: > > struct usb_request's list_head is supposed to be > used only by gadget drivers, but musb is abusing > that. Give struct musb_request its own list_head > and prevent musb from poking into other driver's > business. Hi, I think, the patch misses to fix the usage o

[patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

2011-02-17 Thread Felipe Balbi
struct usb_request's list_head is supposed to be used only by gadget drivers, but musb is abusing that. Give struct musb_request its own list_head and prevent musb from poking into other driver's business. Signed-off-by: Felipe Balbi --- drivers/usb/musb/musb_core.h |4 +- drivers/usb/