Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-09-05 Thread Tony Lindgren
* Woodruff, Richard <[EMAIL PROTECTED]> [080902 10:33]: > Hi, > > > From: David Brownell [mailto:[EMAIL PROTECTED] > > > Actually, this was talked about before a bit and the > > > SZ_xyz flags were left out. > > > > > > The point of telling the geometry in the addition was > > > to be explicit abo

Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-09-02 Thread Steve Sakoman
On Tue, Sep 2, 2008 at 10:23 AM, David Brownell <[EMAIL PROTECTED]> wrote: > (Unrelated: make omap3_beagle_i2c_init be part of beagle_init. > It shouldn't be called on non-beagle hardware; and beagle_init > already runs with other arch_initcall code.) Good catch, I will do the same on the Overo

RE: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-09-02 Thread Woodruff, Richard
Hi, > From: David Brownell [mailto:[EMAIL PROTECTED] > > Actually, this was talked about before a bit and the > > SZ_xyz flags were left out. > > > > The point of telling the geometry in the addition was > > to be explicit about the number of sectors being used. > > So ... this instead? Yes that

Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-09-02 Thread David Brownell
On Friday 29 August 2008, Woodruff, Richard wrote: > Actually, this was talked about before a bit and the > SZ_xyz flags were left out. > > The point of telling the geometry in the addition was > to be explicit about the number of sectors being used. So ... this instead? === CUT HERE From: Dav

Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-08-29 Thread David Brownell
On Friday 29 August 2008, Woodruff, Richard wrote: > > Clean up the Beagle NAND config a bit:  use SZ_128K instead of > > an arithmetic expression for the NAND block size.  Set the > > NAND_BUSWIDTH_16 flag.  Make its init routine static. > > > Actually, this was talked about before a bit and the

RE: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-08-29 Thread Woodruff, Richard
> From: David Brownell <[EMAIL PROTECTED]> > > Clean up the Beagle NAND config a bit: use SZ_128K instead of > an arithmetic expression for the NAND block size. Set the > NAND_BUSWIDTH_16 flag. Make its init routine static. Actually, this was talked about before a bit and the SZ_xyz flags were

[patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups

2008-08-29 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Clean up the Beagle NAND config a bit: use SZ_128K instead of an arithmetic expression for the NAND block size. Set the NAND_BUSWIDTH_16 flag. Make its init routine static. (Unrelated: make omap3_beagle_i2c_init be part of beagle_init. It shouldn't be