* Rick Bronson <[EMAIL PROTECTED]> [081028 09:19]:
> Tony,
>
> The last patch I posted didn't work quite right. It seems we do
> actually come into this macro with none of the pending bits set.
> Presumably, because the interrupt hasn't been ack'd yet. Anyway, I've
> tested this patch and I th
* Rick Bronson <[EMAIL PROTECTED]> [081028 09:19]:
> Tony,
>
> The last patch I posted didn't work quite right. It seems we do
> actually come into this macro with none of the pending bits set.
> Presumably, because the interrupt hasn't been ack'd yet. Anyway, I've
> tested this patch and I th
Tony,
The last patch I posted didn't work quite right. It seems we do
actually come into this macro with none of the pending bits set.
Presumably, because the interrupt hasn't been ack'd yet. Anyway, I've
tested this patch and I think it's golden. It ack's spurious
interrupts and lets the use
Tony,
How does this look?
If we set irq to NR_IRQS then arch/arm/kernel/irq.c will use
bad_irq_desc when it processes the interrupt. NOTE: I haven't tested
this yet.
Rick
--- linux-omap-2.6/arch/arm/plat-omap/include/mach/entry-macro.S.git
2008-10-22 20:01:33.0 -0700
+++ lin
* Rick Bronson <[EMAIL PROTECTED]> [081023 11:13]:
> Tony,
>
> > Well we should let the generic irq handler to do the logging.. But I
> > guess nothing will happen if adm_do_IRQ() does not get called.
> >
> > We could have a dummy handler for some invented higher number that would
> > capture the
Tony,
> Well we should let the generic irq handler to do the logging.. But I
> guess nothing will happen if adm_do_IRQ() does not get called.
>
> We could have a dummy handler for some invented higher number that would
> capture the spurious interrupts I guess.
>
> BTW, ideally we would do the l
Tony,
I checked out some other ARM spurious interrupt handling and it
seems that they ack the interrupt but left the macro with the Z bit
set which means that asm_do_IRQ() does not get called. Seems to me we
should do the same, see the patch below. Although, ideally, we should
be logging these
* Rick Bronson <[EMAIL PROTECTED]> [081022 20:30]:
> Tony,
>
> Here is the patch against the latest git. I'm a little concerned
> about masking the interrupt number so that the spurious bit are
> ignored. Do you really want to turn a spurious interrupt into a
> normal (good) interrupt?
No, bu
Tony,
Here is the patch against the latest git. I'm a little concerned
about masking the interrupt number so that the spurious bit are
ignored. Do you really want to turn a spurious interrupt into a
normal (good) interrupt?
> Also, AFAIK we don't have infinitely repeating irqs any longer, it'
On Thu, Oct 23, 2008 at 12:30 AM, Nathan Monson <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 22, 2008 at 7:46 AM, Felipe Contreras
> <[EMAIL PROTECTED]> wrote:
>> I've reverted the strongly ordered patch and I'm not getting any IRQ
>> issues with any DSP tests, including the ping one.
>>
>> I'm using t
On Wed, Oct 22, 2008 at 7:46 AM, Felipe Contreras
<[EMAIL PROTECTED]> wrote:
> I've reverted the strongly ordered patch and I'm not getting any IRQ
> issues with any DSP tests, including the ping one.
>
> I'm using the latest patches from Hiroshi (20081021), so maybe that
> has something to do with
* Rick Bronson <[EMAIL PROTECTED]> [081022 11:03]:
>
> Sorry if I'm late in the game for changes to entry-macro.S but I
> worked on this code a bit ago and have been testing it. What I have,
> I think, is a little more straight forward. Note that it doesn't have
> the added mask for the spurio
Sorry if I'm late in the game for changes to entry-macro.S but I
worked on this code a bit ago and have been testing it. What I have,
I think, is a little more straight forward. Note that it doesn't have
the added mask for the spurious bits, but it does check for
spurious interrupts and handle
On Wed, Oct 22, 2008 at 1:02 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> * Felipe Contreras <[EMAIL PROTECTED]> [081021 14:34]:
>> On Tue, Oct 21, 2008 at 11:37 PM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
>> > * Felipe Contreras <[EMAIL PROTECTED]> [081021 13:09]:
>> >> On Tue, Oct 21, 2008 at
* Tony Lindgren <[EMAIL PROTECTED]> [081021 15:02]:
> * Felipe Contreras <[EMAIL PROTECTED]> [081021 14:34]:
> > On Tue, Oct 21, 2008 at 11:37 PM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> > > * Felipe Contreras <[EMAIL PROTECTED]> [081021 13:09]:
> > >> On Tue, Oct 21, 2008 at 7:58 AM, Tony Lindg
* Felipe Contreras <[EMAIL PROTECTED]> [081021 14:34]:
> On Tue, Oct 21, 2008 at 11:37 PM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> > * Felipe Contreras <[EMAIL PROTECTED]> [081021 13:09]:
> >> On Tue, Oct 21, 2008 at 7:58 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> >> > Hi all,
> >> >
> >> >
On Tue, Oct 21, 2008 at 11:37 PM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> * Felipe Contreras <[EMAIL PROTECTED]> [081021 13:09]:
>> On Tue, Oct 21, 2008 at 7:58 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
>> > Hi all,
>> >
>> > Here's a bug fix for the irq -33 issue. So far it looks like the ir
* Felipe Contreras <[EMAIL PROTECTED]> [081021 13:09]:
> On Tue, Oct 21, 2008 at 7:58 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> > Hi all,
> >
> > Here's a bug fix for the irq -33 issue. So far it looks like the irq
> > spurious bits just tell that the irq sorting is invalid.
> >
> > This patch
On Tue, Oct 21, 2008 at 7:58 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote:
> Hi all,
>
> Here's a bug fix for the irq -33 issue. So far it looks like the irq
> spurious bits just tell that the irq sorting is invalid.
>
> This patch applies after undoing Lauri's patch
> 5dc857b34441d5c0989b68bf3a488f
ts, so
I'm now looking into that.
Regards,
Tony
commit 3e4291d575f7d694ae1d974a17b4e077b7b721de
Author: Tony Lindgren <[EMAIL PROTECTED]>
Date: Mon Oct 20 14:04:52 2008 -0700
ARM: OMAP3: Fix get_irqnr_and_base to clear spurious interrupt bits
On omap24xx, INTCPS_SIR
20 matches
Mail list logo
