Re: [ARM][OMAP] TWL4030 IRQ

2009-07-01 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: From: Shilimkar, Santosh santosh.shilim...@ti.com Subject: RE: [ARM][OMAP] TWL4030 IRQ To: Kevin Hilman khil...@deeprootsystems.com CC: Russell King - ARM Linux li...@arm.linux.org.uk, linux-arm-ker...@lists.arm.linux.org.uk

RE: [ARM][OMAP] TWL4030 IRQ

2009-06-30 Thread Shilimkar, Santosh
Russell, drivers/mfd/twl4030-irq.c | 55 ++-- 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index bae61b2..4bb1ea7 100644 --- a/drivers/mfd/twl4030-irq.c +++

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-30 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: Kevin/Vikram, Can this patch be included on omap_pm branch to check for any regression? Sure, I have it applied to the PM branch locally, but before I push, can you (or Russell) send me a descriptive changelog for this patch. Thanks, Kevin

RE: [ARM][OMAP] TWL4030 IRQ

2009-06-30 Thread Shilimkar, Santosh
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, July 01, 2009 4:36 AM To: Shilimkar, Santosh Cc: Russell King - ARM Linux; linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org Subject: Re: [ARM][OMAP] TWL4030 IRQ

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-29 Thread Russell King - ARM Linux
On Wed, Jun 24, 2009 at 08:57:56AM +0100, Russell King - ARM Linux wrote: On Wed, Jun 24, 2009 at 01:16:52PM +0530, Shilimkar, Santosh wrote: After digging a bit, the proposed twl_irq change would need some major changes. 1. All the T2(TWL)drivers ( rtc, madc, bci, gpio, keypad, usb,

RE: [ARM][OMAP] TWL4030 IRQ

2009-06-29 Thread Shilimkar, Santosh
And here it is - I've only build-tested it so far. drivers/mfd/twl4030-irq.c | 55 ++-- 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index bae61b2..4bb1ea7 100644 ---

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-29 Thread Russell King - ARM Linux
On Mon, Jun 29, 2009 at 09:04:53PM +0530, Shilimkar, Santosh wrote: Russell, Just a question here. In the enable_irq(irq) and disable_irq(irq) call tree, internally there are calls to the interrupt controller chip. In disable_irq() path: desc-chip-disable(irq); And in

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-29 Thread Russell King - ARM Linux
On Mon, Jun 29, 2009 at 10:51:09AM -0700, Kevin Hilman wrote: And if you look at the OMAP's MPU irq_chip implementation, these are not populated either. We rely on the default lazy enable via unmask and the lazy disable. There's no lazy enable - it's immediate. There's only lazy disable. --

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-29 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Mon, Jun 29, 2009 at 10:51:09AM -0700, Kevin Hilman wrote: And if you look at the OMAP's MPU irq_chip implementation, these are not populated either. We rely on the default lazy enable via unmask and the lazy disable. There's no

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-24 Thread Russell King - ARM Linux
On Wed, Jun 24, 2009 at 10:37:45AM +0530, Shilimkar, Santosh wrote: Russell, After digging a bit, the proposed twl_irq change would need some major 1. All the T2(TWL)drivers ( rtc, madc, bci, gpio, keypad, usb, mmc)needs 2.Above also helps to have useful entries like /proc/interrupts/rtc

Re: [ARM][OMAP] TWL4030 IRQ

2009-06-24 Thread Russell King - ARM Linux
On Wed, Jun 24, 2009 at 01:16:52PM +0530, Shilimkar, Santosh wrote: After digging a bit, the proposed twl_irq change would need some major changes. 1. All the T2(TWL)drivers ( rtc, madc, bci, gpio, keypad, usb, mmc)needs modification.Currently twl_irq fw implements kind of twl4030_irq_chip

RE: [ARM][OMAP] TWL4030 IRQ

2009-06-23 Thread Shilimkar, Santosh
Russell, After digging a bit, the proposed twl_irq change would need some major changes. 1. All the T2(TWL)drivers ( rtc, madc, bci, gpio, keypad, usb, mmc)needs modification. Currently twl_irq fw implements kind of twl4030_irq_chip which allows all the T2 drivers to get virtual interrupt